From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 017322737F9; Fri, 13 Feb 2026 16:28:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771000130; cv=none; b=CgC9uYqQ340yTCrZevUJosPOnknkngp0vH/Ek4XfrRP7abTFiCGQMDQdqOpwRdcXuYvqcjuzuIobnsY+rMyua7PjdK/PzT9t3NiKfJzIrgElMYCqzIPvqKhBOvmd5LEZouQfEymxjXpkwmwKFqYGCwQPFUCR1ZyyUsYG2Dl2gag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771000130; c=relaxed/simple; bh=Is8B/gAp14/MAcFbg96ZIgqDeyXZZUZIPxoz/Mhgjws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DL9z3d3vmaHWJmyRvqXLkthlQOUvIcHm3nsTY9vPqgHEF7LnKqbD1j29EBGMTfcL1Bk8ABWTpnzqqcPwGYIQ4yQQFAZQwCzWzVbRGqndUWqDN2hfQHO69xw2jPlfBF/CN7AzVJUre5al8saFklZgQaQvC07q9DP2/I3xNvmNMyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LsnOws9q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LsnOws9q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6DE2C116C6; Fri, 13 Feb 2026 16:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771000129; bh=Is8B/gAp14/MAcFbg96ZIgqDeyXZZUZIPxoz/Mhgjws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LsnOws9qOYK9BK+e43Z10TNiZYYnSMw0ragyjrqS86ru8HCDfTHQvr6xnLjVukd5A vXPZZtp9dSwRki4+yTsVpohKYfrptdvspvAhStd1mM6VdDrHMIrbFNgC2sZtG+7Phh 2DuFk0Nh1Vk6hFXUKGeqgAKvVk0BpI/lrh9YCeSwTe2j7ZgXMzUb59FKJsqTPQHd+I IshzYTj4pOMJ+/F6ynT0fZevQw3dXRr/bSP0yLXywyV/U6IU+njUT3lpWem2kovUgc DBeAecVActHylnElyeJ466SHK5tx2ccvewQDcvErlQMk0AqDNjQXKXBQuvUTAn/wZ/ J1UsBRCwK/x2g== Date: Fri, 13 Feb 2026 16:14:04 +0100 From: Nicolas Schier To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Nathan Chancellor , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Bouchinet , Xiu Jianfeng , Fabian =?iso-8859-1?Q?Gr=FCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?iso-8859-1?Q?C=E2ju?= Mihai-Drosi , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH v4 11/17] module: Move lockdown check into generic module loader Message-ID: Mail-Followup-To: Nicolas Schier , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Nathan Chancellor , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Bouchinet , Xiu Jianfeng , Fabian =?iso-8859-1?Q?Gr=FCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?iso-8859-1?Q?C=E2ju?= Mihai-Drosi , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org References: <20260113-module-hashes-v4-0-0b932db9b56b@weissschuh.net> <20260113-module-hashes-v4-11-0b932db9b56b@weissschuh.net> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260113-module-hashes-v4-11-0b932db9b56b@weissschuh.net> On Tue, Jan 13, 2026 at 01:28:55PM +0100, Thomas Weißschuh wrote: > The lockdown check buried in module_sig_check() will not compose well > with the introduction of hash-based module validation. > Move it into module_integrity_check() which will work better. > > Signed-off-by: Thomas Weißschuh > --- > kernel/module/main.c | 6 +++++- > kernel/module/signing.c | 3 +-- > 2 files changed, 6 insertions(+), 3 deletions(-) > Reviewed-by: Nicolas Schier