From: "Günther Noack" <gnoack@google.com>
To: Tingmao Wang <m@maowtm.org>
Cc: "Mickaël Salaün" <mic@digikod.net>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] landlock: Add counted_by and fix comment in landlock_ruleset
Date: Mon, 9 Feb 2026 10:47:52 +0100 [thread overview]
Message-ID: <aYmtSHwoCdcek4Ev@google.com> (raw)
In-Reply-To: <20260208235449.1124354-1-m@maowtm.org>
On Sun, Feb 08, 2026 at 11:54:48PM +0000, Tingmao Wang wrote:
> For a domain, this array stores the access masks for each layer (of
> which there are num_layers of them). For an unmerged ruleset, we have
> one "layer", and one element in this array. This annotation serves as
> useful documentation.
>
> This also removes a comment saying that num_layers = 0 for unmerged
> rulesets, which is incorrect (it is 1).
>
> Signed-off-by: Tingmao Wang <m@maowtm.org>
Reviewed-by: Günther Noack <gnoack@google.com>
Thank you for fixing this! We should use these bounds check macros
wherever we can, IMHO. Removing the remark about num_layers=0 is also
correct.
—Günther
next prev parent reply other threads:[~2026-02-09 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 23:54 [PATCH] landlock: Add counted_by and fix comment in landlock_ruleset Tingmao Wang
2026-02-09 9:47 ` Günther Noack [this message]
2026-02-09 17:28 ` Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYmtSHwoCdcek4Ev@google.com \
--to=gnoack@google.com \
--cc=linux-security-module@vger.kernel.org \
--cc=m@maowtm.org \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox