From: "Günther Noack" <gnoack@google.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: linux-security-module@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
Miguel Ojeda <ojeda@kernel.org>
Subject: Re: [PATCH v1] landlock: Update formatting
Date: Wed, 8 Jul 2026 17:30:28 +0200 [thread overview]
Message-ID: <ak5s9LrUnrxlRjDQ@google.com> (raw)
In-Reply-To: <20260708110635.2083515-1-mic@digikod.net>
On Wed, Jul 08, 2026 at 01:06:33PM +0200, Mickaël Salaün wrote:
> Following commit 99df2a8eba34 ("clang-format: fix formatting of guard()
> and scoped_guard() statements"), update scoped_guard() formatting.
> Also, see the related fix [1].
>
> Cc: Günther Noack <gnoack@google.com>
> Cc: Miguel Ojeda <ojeda@kernel.org>
> Link: https://lore.kernel.org/r/20260708105713.2073335-1-mic@digikod.net [1]
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> ---
> security/landlock/task.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/security/landlock/task.c b/security/landlock/task.c
> index 7ddf211f75c3..360d226d0f51 100644
> --- a/security/landlock/task.c
> +++ b/security/landlock/task.c
> @@ -95,8 +95,7 @@ static int hook_ptrace_access_check(struct task_struct *const child,
> if (!parent_subject)
> return 0;
>
> - scoped_guard(rcu)
> - {
> + scoped_guard(rcu) {
> const struct landlock_ruleset *const child_dom =
> landlock_get_task_domain(child);
> err = domain_ptrace(parent_subject->domain, child_dom);
> @@ -370,8 +369,7 @@ static int hook_task_kill(struct task_struct *const p,
> if (!subject)
> return 0;
>
> - scoped_guard(rcu)
> - {
> + scoped_guard(rcu) {
> is_scoped = domain_is_scoped(subject->domain,
> landlock_get_task_domain(p),
> signal_scope.scope);
> @@ -422,8 +420,7 @@ static int hook_file_send_sigiotask(struct task_struct *tsk,
> if (task_tgid(tsk) == landlock_file(fown->file)->fown_tg)
> return 0;
>
> - scoped_guard(rcu)
> - {
> + scoped_guard(rcu) {
> is_scoped = domain_is_scoped(subject->domain,
> landlock_get_task_domain(tsk),
> signal_scope.scope);
> --
> 2.54.0
Reviewed-by: Günther Noack <gnoack@google.com>
prev parent reply other threads:[~2026-07-08 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 11:06 [PATCH v1] landlock: Update formatting Mickaël Salaün
2026-07-08 15:30 ` Günther Noack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak5s9LrUnrxlRjDQ@google.com \
--to=gnoack@google.com \
--cc=bvanassche@acm.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox