From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9403C00449 for ; Wed, 3 Oct 2018 19:24:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 138E9206B2 for ; Wed, 3 Oct 2018 19:24:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 138E9206B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=namei.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726966AbeJDCNy (ORCPT ); Wed, 3 Oct 2018 22:13:54 -0400 Received: from namei.org ([65.99.196.166]:35482 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726884AbeJDCNy (ORCPT ); Wed, 3 Oct 2018 22:13:54 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id w93JO70D017416; Wed, 3 Oct 2018 19:24:07 GMT Date: Thu, 4 Oct 2018 05:24:07 +1000 (AEST) From: James Morris To: David Howells cc: denkenz@gmail.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/22] KEYS: Provide software public key query function In-Reply-To: <153618449119.7946.11025480207548147086.stgit@warthog.procyon.org.uk> Message-ID: References: <153618445730.7946.10001472635835806478.stgit@warthog.procyon.org.uk> <153618449119.7946.11025480207548147086.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Wed, 5 Sep 2018, David Howells wrote: > + if (strcmp(encoding, "raw") == 0) { > + strcpy(alg_name, pkey->pkey_algo); > + return 0; > + } Can encoding here also be NULL to indicate raw? per patch 01: > +struct kernel_pkey_params { > + struct key *key; > + const char *encoding; /* Encoding (eg. "oaep" or NULL for raw) */ -- James Morris