From: James Morris <jmorris@namei.org>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 2/3] smack: Check address length before reading address family
Date: Tue, 30 Apr 2019 05:58:56 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1904300558310.20645@namei.org> (raw)
In-Reply-To: <738815cc-ac59-63c9-1768-26df95689d7a@schaufler-ca.com>
On Fri, 12 Apr 2019, Casey Schaufler wrote:
> On 4/12/2019 3:59 AM, Tetsuo Handa wrote:
> > KMSAN will complain if valid address length passed to bind()/connect()/
> > sendmsg() is shorter than sizeof("struct sockaddr"->sa_family) bytes.
> >
> > Also, since smk_ipv6_port_label()/smack_netlabel_send()/
> > smack_ipv6host_label()/smk_ipv6_check()/smk_ipv6_port_check() are not
> > checking valid address length and/or address family, make sure we check
> > both. The minimal valid length in smack_socket_connect() is changed from
> > sizeof(struct sockaddr_in6) bytes to SIN6_LEN_RFC2133 bytes, for it seems
> > that Smack is not using "struct sockaddr_in6"->sin6_scope_id field.
> >
> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>
> Acked-by: Casey Schaufler <casey@schaufler-ca.com>
Casey: will you be taking this via your tree?
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2019-04-29 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 10:59 [PATCH 1/3] selinux: Check address length before reading address family Tetsuo Handa
2019-04-12 10:59 ` [PATCH 2/3] smack: " Tetsuo Handa
2019-04-12 15:32 ` Casey Schaufler
2019-04-29 19:58 ` James Morris [this message]
2019-04-29 20:21 ` Casey Schaufler
2019-04-12 10:59 ` [PATCH 3/3] tomoyo: " Tetsuo Handa
2019-04-29 20:06 ` James Morris
2019-04-15 16:46 ` [PATCH 1/3] selinux: " Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1904300558310.20645@namei.org \
--to=jmorris@namei.org \
--cc=casey@schaufler-ca.com \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox