Re: [PATCH] tomoyo: Don't emit WARNING: string while fuzzing testing.

[James Morris <jmorris@namei.org>]

On Tue, 7 May 2019, Tetsuo Handa wrote:

> Commit cff0e6c3ec3e6230 ("tomoyo: Add a kernel config option for fuzzing
> testing.") enabled the learning mode, and syzbot started crashing by
> encountering this warning message. Disable this warning if built for
> fuzzing testing; otherwise syzbot can't start fuzzing testing.

syzbot crashed? Sounds like a bug in syzbot which should be fixed rather 
than this approach.


> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> ---
>  security/tomoyo/util.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/security/tomoyo/util.c b/security/tomoyo/util.c
> index 0517cbd..52752e1 100644
> --- a/security/tomoyo/util.c
> +++ b/security/tomoyo/util.c
> @@ -1076,8 +1076,10 @@ bool tomoyo_domain_quota_is_ok(struct tomoyo_request_info *r)
>  		domain->flags[TOMOYO_DIF_QUOTA_WARNED] = true;
>  		/* r->granted = false; */
>  		tomoyo_write_log(r, "%s", tomoyo_dif[TOMOYO_DIF_QUOTA_WARNED]);
> +#ifndef CONFIG_SECURITY_TOMOYO_INSECURE_BUILTIN_SETTING
>  		pr_warn("WARNING: Domain '%s' has too many ACLs to hold. Stopped learning mode.\n",
>  			domain->domainname->name);
> +#endif
>  	}
>  	return false;
>  }
> 

-- 
James Morris
<jmorris@namei.org>