From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C20783D3338 for ; Wed, 22 Jul 2026 21:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784754742; cv=none; b=c0jmwvqkJju6iKhmKKlWYC7BYlsnDuu4V8WVAAYCu7Esy5AuKKjE/onK0wKGhP923e/6xSlV5cb7QIY8hpjvfGuhNRlF8jeozPO32obkEFzW0R+MVs3m+MVgmdzxw9hhHz17sMIGdhPMQg4sjygcMcH593TNusZqpvqEpoxxEwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784754742; c=relaxed/simple; bh=1v6byf3doib7lXScxa29tBKEg951i25yQTkCyjE1yPs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gEJYedpijB5m8IWLeUM/grWfV0Ca5RNbihkiWWlStl/bBlk3TR1ATaWpZyoYPua9fe0RL3z8mQ+Oo1pr+rikevfhrEk8DHHU9KxvhUfhCavSjnXzGjy1F5SBsmFbCuN7CTNDOG/rp7ePzPPM9IDaXgF+3++Sul2oEmqetGXW+gE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kQuLZ68g; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kQuLZ68g" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-81ed2a00f12so104398037b3.2 for ; Wed, 22 Jul 2026 14:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784754740; x=1785359540; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=P2hAbTXYH7pOCgQd3BSSUl5pvihpdrNJ4HnSdNTSi5I=; b=kQuLZ68gyxWKJQ2gs/HgMp+PJit3Cr0HMKMogYgF5qHjH0nKQvjSAlqLEX4LvFy/AM MQ+L8xJmxIebXpPDA8rqHPtJxb8o3C27zYkxaF+I5DRxTVibotKKia6OB4zFjV5gaEQx zQTBb5VPnhwcFJmR6LG4MzgdFW6yaqLekmlJaqqigcwgvWWn63FX6HnLxxvyyPe3Yp4b tUyptGNNnWgyXuVtl0oOwmihcS4hv/3QPi0Lbkfyl5Mfq7hb9bkEvrN8ewJpd5a+He+8 XAZpQHTiY0d+OmlaZT5Hm+21ae6If4I7Upt8wk4kK2VrbrPiXkMzvDMZ1J5qwymIk8YQ 4CUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784754740; x=1785359540; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=P2hAbTXYH7pOCgQd3BSSUl5pvihpdrNJ4HnSdNTSi5I=; b=c9CI6ci1YHjae3emMbq0Zp8r4IeoqyLRcJHFfH3bfEWaDs/40xFignnmmL402lInd5 t+nwZolSHETC8ZQhhP4KhYlBAFDGfHkr1Bga/RUyXAEmBb5dsjj2BpTEEhsl3lU/QFUW niOLWDJNegSu2exxtQqhxAOZaPpFxzBJl4j4w6MRXXf0RNBhCOalLhS3kIqARCdOcLla ImOD+X2J0zn08p/9riSj1dw+jFIFJNfgbcQjXZxA8XmdID4VoBMw3+5dWnCcbqFGMUxP Ia6mTLfJlHD3G5a8bkoUZgYIoFNTD9BaVZhw0sr49avdJrXHrmq/DFN2SSIXE64FsP7n K+eg== X-Forwarded-Encrypted: i=1; AHgh+RpDBAX6a08SmRHpE1H4fcloTrkGh/Ia9vZ7FbmZRXyUybiMg6THLpLg8eDNxA8xvU32Zbizv/tefCrpid+EosIubcBstyY=@vger.kernel.org X-Gm-Message-State: AOJu0YzwHUy+8jwjj5jKly3kLa8DIcZVRiGQbgU3gzRKBl473uZ3yHt3 W22lS/y6ISuaZL1wxjvTC2eLWzsM/d6FUGQEnzRJSTtoAYvSk/30FZhs X-Gm-Gg: AR+sD12TqXW6Zj7gCt/pYjNfEwExc/y3Cyu8n2tqim2yVb9qzwQgn6tT8gBkn2+iVx9 maqf8K4T0Ovx1sCCoOKumHo+syGaAliFL2ObHNaPr6jM6Nwxm2qxK+Vbc1ODcme7movQj/YgXrY VH+goj91sNIJNcltFILZovUp8MMaxTp+itCsCKwSkZ20L5/DQokq3NX8UwBNkURPJr0XoWhplCm 3TMc0jbtdsuwSmR00mnLxAgzETiNguRrZ4+qZTX72TV2ZmIDQZqI/xVVkxU4PtOPmG9pRfcVSNm WI/SWmvLeSyie4ElQxuY+Z7HukMbviy3LSrTMaji15iIaAStI1jxjLRyp7OkFmd4PoRWjVZs09W REa0UCVn8UbkY+1P7tpw0guq3kkMXUN2o4SUVeHlj3OSdDmGLDg6P9f3v38lubwpu2/NYI9VUTi uFzYbfZxFkGsNuIV6JrNyk6D9H8BySi34Iup5d X-Received: by 2002:a05:690c:2784:b0:7e8:a091:6c4b with SMTP id 00721157ae682-81f4c1c1d2dmr953507b3.24.1784754739786; Wed, 22 Jul 2026 14:12:19 -0700 (PDT) Received: from zenbox ([2600:1700:18fb:6011:4392:41cd:1ce2:e391]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81f3dc4422dsm12662287b3.13.2026.07.22.14.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 14:12:19 -0700 (PDT) Date: Wed, 22 Jul 2026 17:12:18 -0400 From: Justin Suess To: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= Cc: =?utf-8?Q?G=C3=BCnther?= Noack , Steven Rostedt , Christian Brauner , Jann Horn , Jeff Xu , Kees Cook , Masami Hiramatsu , Mathieu Desnoyers , Matthieu Buffet , Mikhail Ivanov , Tingmao Wang , kernel-team@cloudflare.com, linux-security-module@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/20] landlock: Split struct landlock_domain from struct landlock_ruleset Message-ID: References: <20260722171159.2776765-1-mic@digikod.net> <20260722171159.2776765-4-mic@digikod.net> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260722171159.2776765-4-mic@digikod.net> On Wed, Jul 22, 2026 at 07:11:35PM +0200, Mickaël Salaün wrote: > Switch all domain users to the new struct landlock_domain type > introduced by a previous commit, eliminating the conflation between > mutable rulesets and immutable domains. landlock_merge_ruleset() now > returns and allocates a struct landlock_domain, and the merge and > inherit helpers move next to it; the former static insert_rule() is > exported as landlock_rule_insert() for its new caller across the > translation-unit boundary. > Seems a little confusing that we have landlock_rule_insert() and landlock_insert_rule() Maybe a rename of one these would be appropriate? Otherwise looks good :) Justin > [...]