From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF294457DF; Mon, 7 Sep 2026 12:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788784068; cv=none; b=sKC9lvR1slczIDecP3Q4usUjBZQFo+/VC2oRW9+9ovG754EjwVqzgU3N/BchV3hX1EusJcqL3oelxKV0BZDIBkle2F3aEzfuQQlQunKqllhA0Wm+zOpS0yJRQ88YZnNE7WtZ1VXYLT9r6HmauWBP1kzhabL/HSNEJ34BVua+rzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788784068; c=relaxed/simple; bh=7mQysol0nqGy28oauyhZgyxyGpxSOclDpukalT6XJ3I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=euQAcr4Mk/vLH3jcs3n6DbVXwdQylpx3/oiL2FeY44tTgFgHZeMNvZCnQQsadAE6E+XDShtiBKMHewApMLL2QEiGFHBKdSihI2OR/vpyOGLOGif6zSlbWMmga4eitZPC+VoTiIXR6xyqKUYtmINSO9gjf9c/DxLwu4lWQhxC2I4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XRC2+2eu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XRC2+2eu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B18D71F00A3A; Mon, 7 Sep 2026 12:27:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788784067; bh=WlAfg5iXl7FPl5nf6qTFBdMw/OruKYjbvrYea3+Uz98=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=XRC2+2eun6nn01MuOy3pLsHfxu9LlV+nJ/7enwoG457a25DF4U95wpahgGNE/Mkpl rLWt1ASQbCeSG/i9QLz1ZnPcaCy6u4EsPOMutcqfGQwolvE3pFYvj3CLi0gH/jHIaP VSX9+ZExqzazlzJ/gYokn6P0ZUcZVcJyNCXQ1YbNatoMUV8yAdvk5jDDyWamOxAvv3 +7aUUDC5HzU5NJnVD+GkGmgbm6fa2/R9eIMCLeZ3Ns7wFIlGEhWI+Y0nIqbVg2rjid pJOLNmP3BAjh+U1aeOA7DovmGfdTvNbJn34KVmWPthoAFJm0y6LO+cDAw3Iwnhc/n6 Nx/Wwb0dP0rPg== Date: Mon, 7 Sep 2026 13:27:32 +0100 From: "Lorenzo Stoakes (ARM)" To: Ye Liu Cc: Andrew Morton , Ye Liu , Michal Hocko , peterz@infradead.org, paulmck@kernel.org, mingo@redhat.com, rostedt@goodmis.org, jpoimboe@kernel.org, mic@digikod.net, oleg@redhat.com, tglx@kernel.org, david@kernel.org, linmiaohe@huawei.com, nao.horiguchi@gmail.com, rafael@kernel.org, gnoack3000@gmail.com, sj@kernel.org, rientjes@google.com, shakeel.butt@linux.dev, xu.xin16@zte.com.cn, chengming.zhou@linux.dev, will@kernel.org, boqun@kernel.org, frederic@kernel.org, neeraj.upadhyay@kernel.org, joelagnelf@nvidia.com, josh@joshtriplett.org, urezki@gmail.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, tony.luck@intel.com, reinette.chatre@intel.com, x86@kernel.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pavel@kernel.org, lance.yang@linux.dev, mhiramat@kernel.org, pmladek@suse.com, longman@redhat.com, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, qiang.zhang@linux.dev, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, mark.rutland@arm.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rcu@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v2 7/8] lib: convert process iterator to for_each_process_rculock Message-ID: References: <20260907081334.1152889-1-ye.liu@linux.dev> <20260907081334.1152889-8-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260907081334.1152889-8-ye.liu@linux.dev> On Mon, Sep 07, 2026 at 04:13:33PM +0800, Ye Liu wrote: > From: Ye Liu > > Replace the manual rcu_read_lock()/rcu_read_unlock() pair combined > with for_each_process() loop in lib/ with for_each_process_rculock(), > which scopes the RCU read lock to the loop body via scoped_guard(rcu). > > No functional change. > > Signed-off-by: Ye Liu > Acked-by: Michal Hocko LGTM so: Reviewed-by: Lorenzo Stoakes (ARM) > --- > Changes in v2: > - Rename *_rcu to *_rculock > lib/is_single_threaded.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/lib/is_single_threaded.c b/lib/is_single_threaded.c > index 8c98b20bfc41..4e7fe85454ab 100644 > --- a/lib/is_single_threaded.c > +++ b/lib/is_single_threaded.c > @@ -26,8 +26,7 @@ bool current_is_single_threaded(void) > return true; > > ret = false; > - rcu_read_lock(); > - for_each_process(p) { > + for_each_process_rculock(p) { > if (unlikely(p->flags & PF_KTHREAD)) > continue; > if (unlikely(p == task->group_leader)) > @@ -48,7 +47,5 @@ bool current_is_single_threaded(void) > } > ret = true; > found: > - rcu_read_unlock(); > - > return ret; > } > -- > 2.25.1 > -- Cheers, Lorenzo