From: Jarkko Sakkinen <jarkko@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/8] KEYS: rhashtable bug fixes
Date: Mon, 19 Oct 2026 17:33:56 +0300 [thread overview]
Message-ID: <atYqVKhU8N5R1gnE@kernel.org> (raw)
In-Reply-To: <20261019142516.300040-1-jarkko@kernel.org>
On Mon, Oct 19, 2026 at 05:25:00PM +0300, Jarkko Sakkinen wrote:
> My patch set that migrates assoc_array to rhashtable had some LLM
> scavegend bug fixes. Unfortunately most them where either plain wrong or
> not in the right scope. The bug fixes in this patch set are by human
> labour constructed fully but they are derived from what I got out of the
> original LLM source. Thus, they are tagged as LLM assisted.
I like to document any possible LLM association mostly for
self-reflection. I'm still adapting and not fully comfortable
with every detail so this gives a chance to look back and
learn how to do things better in the future.
So I'm neither supporter or desupporter of LLMs but more
like representing the "I don't know what to think about this"
camp :-)
Somewhat fuzzy opinion I have that more guards and checks
should be set to the patch submission process to address
"proxy contributors". At high rate such fixes are right
bug but wrong fix type of situations where author is
really not an author but instead a reporter. This is both
time consuming and unfair for legit contributors.
>
> Jarkko Sakkinen (8):
> KEYS: Change the type of key->quotalen to unsigned int
> KEYS: Change the type of key->datalen to unsigned int
> KEYS: Reject @desclen values over U16_MAX in key_alloc()
> KEYS: Prevent overflow of user->qnkeys in key_alloc()
> KEYS: Prevent overflow of quota in key_alloc()
> KEYS: Prevent overflow of user->qnbytes in key_alloc()
> KEYS: Reject @datalen values over INT_MAX
> KEYS: Verify the key identity in __keyctl_unlink
>
> include/linux/key.h | 4 ++--
> security/keys/key.c | 13 ++++++++++++-
> security/keys/keyring.c | 6 ++++++
> 3 files changed, 20 insertions(+), 3 deletions(-)
>
> --
> 2.47.3
>
Br, Jarkko
prev parent reply other threads:[~2026-10-19 14:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 14:25 [RFC PATCH 0/8] KEYS: rhashtable bug fixes Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 1/8] KEYS: Change the type of key->quotalen to unsigned int Jarkko Sakkinen
2026-10-19 15:37 ` sashiko-bot
2026-10-19 14:25 ` [RFC PATCH 2/8] KEYS: Change the type of key->datalen " Jarkko Sakkinen
2026-10-19 15:33 ` David Howells
2026-10-19 16:31 ` Jarkko Sakkinen
2026-10-19 15:41 ` sashiko-bot
2026-10-19 14:25 ` [RFC PATCH 3/8] KEYS: Reject @desclen values over U16_MAX in key_alloc() Jarkko Sakkinen
2026-10-19 15:35 ` David Howells
2026-10-19 16:32 ` Jarkko Sakkinen
2026-10-19 15:49 ` sashiko-bot
2026-10-19 14:25 ` [RFC PATCH 4/8] KEYS: Prevent overflow of user->qnkeys " Jarkko Sakkinen
2026-10-19 16:02 ` sashiko-bot
2026-10-19 14:25 ` [RFC PATCH 5/8] KEYS: Prevent overflow of quota " Jarkko Sakkinen
2026-10-19 15:40 ` David Howells
2026-10-19 16:33 ` Jarkko Sakkinen
2026-10-19 16:16 ` sashiko-bot
2026-10-19 14:25 ` [RFC PATCH 6/8] KEYS: Prevent overflow of user->qnbytes " Jarkko Sakkinen
2026-10-19 15:41 ` David Howells
2026-10-19 16:34 ` Jarkko Sakkinen
2026-10-19 16:18 ` sashiko-bot
2026-10-19 14:25 ` [RFC PATCH 7/8] KEYS: Reject @datalen values over INT_MAX Jarkko Sakkinen
2026-10-19 15:43 ` David Howells
2026-10-19 16:35 ` Jarkko Sakkinen
2026-10-19 16:21 ` sashiko-bot
2026-10-19 14:25 ` [RFC PATCH 8/8] KEYS: Verify the key identity in __keyctl_unlink Jarkko Sakkinen
2026-10-19 15:55 ` David Howells
2026-10-19 16:37 ` Jarkko Sakkinen
2026-10-19 16:23 ` sashiko-bot
2026-10-19 14:33 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atYqVKhU8N5R1gnE@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox