Linux Security Modules development
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: David Howells <dhowells@redhat.com>,
	Eric Biggers <ebiggers@kernel.org>,
	Mimi Zohar <zohar@linux.ibm.com>,
	Roberto Sassu <roberto.sassu@huawei.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	Eric Snowberg <eric.snowberg@oracle.com>,
	Paul Moore <paul@paul-moore.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"open list:KEYS/KEYRINGS" <keyrings@vger.kernel.org>,
	"open list:SECURITY SUBSYSTEM"
	<linux-security-module@vger.kernel.org>
Subject: Re: [RFC PATCH 2/4] KEYS: Pin the backing module for struct key_type
Date: Mon, 2 Nov 2026 14:41:04 +0200	[thread overview]
Message-ID: <auiE4Iabcbro4LiW@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-193418@kernel.org>

On Mon, Nov 02, 2026 at 12:32:55PM +0000, sashiko-bot@kernel.org wrote:
> drivers/nvme/common/keyring.c:nvme_keyring_exit() {
> 	unregister_key_type(&nvme_tls_psk_key_type);
> 	key_revoke(nvme_keyring);
> 	key_put(nvme_keyring);
> }
> 
> fs/nfs/nfs4idmap.c:nfs_idmap_quit() {
> 	key_revoke(id_resolver_cache->thread_keyring);
> 	unregister_key_type(&key_type_id_resolver);
> 	unregister_key_type(&key_type_id_resolver_legacy);
> 	put_cred(id_resolver_cache);
> }
> 
> fs/smb/client/cifsacl.c:exit_cifs_idmap() {
> 	key_revoke(root_cred->thread_keyring);
> 	unregister_key_type(&cifs_idmap_key_type);
> 	put_cred(root_cred);
> 	cifs_dbg(FYI, "Unregistered %s key type\n", cifs_idmap_key_type.name);
> }
> 
> net/dns_resolver/dns_key.c:exit_dns_resolver() {
> 	key_revoke(dns_resolver_cache->thread_keyring);
> 	unregister_key_type(&key_type_dns_resolver);
> 	put_cred(dns_resolver_cache);
> }

I did this on purpose to check which sites Sashiko detects so this was
expected outcome.

I'll address all the Sashiko issues and send v2 so that they are out
of the way.

Br, Jarkko

  reply	other threads:[~2026-11-02 12:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 12:15 [RFC PATCH 0/4] KEYS: sanitize the garbage collector behavior Jarkko Sakkinen
2026-11-02 12:15 ` [RFC PATCH 1/4] KEYS: trusted: Disable sysfs bind attributes for TEE driver Jarkko Sakkinen
2026-11-02 12:27   ` sashiko-bot
2026-11-02 12:15 ` [RFC PATCH 2/4] KEYS: Pin the backing module for struct key_type Jarkko Sakkinen
2026-11-02 12:22   ` Jarkko Sakkinen
2026-11-02 12:32   ` sashiko-bot
2026-11-02 12:41     ` Jarkko Sakkinen [this message]
2026-11-02 12:15 ` [RFC PATCH 3/4] KEYS: Remove key_type_dead Jarkko Sakkinen
2026-11-02 12:21   ` Jarkko Sakkinen
2026-11-02 12:35   ` sashiko-bot
2026-11-02 12:15 ` [RFC PATCH 4/4] KEYS: key_garbage_collector(): process in chunks Jarkko Sakkinen
2026-11-02 12:31   ` Jarkko Sakkinen
2026-11-02 12:32   ` sashiko-bot
2026-11-02 13:34     ` Jarkko Sakkinen
2026-11-02 12:19 ` [RFC PATCH 0/4] KEYS: sanitize the garbage collector behavior Jarkko Sakkinen
2026-11-03  0:03 ` Jarkko Sakkinen
2026-11-03  0:42   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auiE4Iabcbro4LiW@kernel.org \
    --to=jarkko@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=ebiggers@kernel.org \
    --cc=eric.snowberg@oracle.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=roberto.sassu@huawei.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=serge@hallyn.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox