Linux Security Modules development
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Sinan Turunc <enscrpt@pm.me>
Cc: David Howells <dhowells@redhat.com>,
	paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
	keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] keys: serialise key instantiation against keyctl_chown_key()
Date: Tue, 17 Nov 2026 18:23:07 +0200	[thread overview]
Message-ID: <avx_axeHCenqxY_G@kernel.org> (raw)
In-Reply-To: <avx_Eu0rbWtwPDGK@kernel.org>

On Tue, Nov 17, 2026 at 06:21:43PM +0200, Jarkko Sakkinen wrote:
> On Tue, Nov 17, 2026 at 12:34:12PM +0000, Sinan Turunc wrote:
> > Subclass 2 is an unused lockdep subclass that is
> > only ever taken inside key_construction_mutex. Subclasses 0 and 1 are
> > already taken outside keyring_serialise_link_lock by __key_link_lock() and
> > __key_move_lock().
> 
> Delete also this as there was no bug associated with nesting levels.
> 
> And this does not need additional fixes despite I forewarned about that.
> 
> I'll wait for v3.

"Take key->sem for write with down_write_nested(&key->sem, 2) inside
key_construction_mutex in __key_instantiate_and_link() and
key_reject_and_link()."

This sentence tells everything about nesting that this patch requires.

Br, Jarkko

      reply	other threads:[~2026-11-17 16:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 12:34 [PATCH v2] keys: serialise key instantiation against keyctl_chown_key() Sinan Turunc
2026-11-17 12:48 ` sashiko-bot
2026-11-17 12:49 ` Jarkko Sakkinen
2026-11-17 12:52   ` Jarkko Sakkinen
2026-11-17 14:53 ` Jarkko Sakkinen
2026-11-17 16:21 ` Jarkko Sakkinen
2026-11-17 16:23   ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avx_axeHCenqxY_G@kernel.org \
    --to=jarkko@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=enscrpt@pm.me \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox