From: Paul Moore <paul@paul-moore.com>
To: Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org
Cc: torvalds@linux-foundation.org, brauner@kernel.org, jack@suse.cz,
neil@brown.name, linux-security-module@vger.kernel.org,
dhowells@redhat.com, linkinjeon@kernel.org
Subject: Re: [PATCH 1/6] security_dentry_init_security(): constify qstr argument
Date: Thu, 11 Sep 2025 16:54:20 -0400 [thread overview]
Message-ID: <b042d4c28324441644cfd8e3d7733477@paul-moore.com> (raw)
In-Reply-To: <20250911050534.3116491-1-viro@zeniv.linux.org.uk>
On Sep 11, 2025 Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Nothing outside of fs/dcache.c has any business modifying
> dentry names; passing &dentry->d_name as an argument should
> have that argument declared as a const pointer.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Acked-by: Casey Schaufler <casey@schaufler-ca.com>
> Reviewed-by: David Howells <dhowells@redhat.com>
> ---
> include/linux/lsm_hook_defs.h | 2 +-
> include/linux/security.h | 4 ++--
> security/security.c | 2 +-
> security/selinux/hooks.c | 2 +-
> security/smack/smack_lsm.c | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
LSM and SELinux bits look fine to me. Al, I'm guessing you would
prefer to take this patch as part of the larger patchset, but if you
want me to take this single patch for the upcoming merge window let
me know.
Acked-by: Paul Moore <paul@paul-moore.com>
--
paul-moore.com
next prev parent reply other threads:[~2025-09-11 20:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 5:01 [PATCHES] simple part of ->d_name stuff Al Viro
2025-09-11 5:05 ` [PATCH 1/6] security_dentry_init_security(): constify qstr argument Al Viro
2025-09-11 5:05 ` [PATCH 2/6] exfat_find(): " Al Viro
2025-09-11 6:02 ` Namjae Jeon
2025-09-15 12:45 ` Christian Brauner
2025-09-11 5:05 ` [PATCH 3/6] afs_edit_dir_{add,remove}(): " Al Viro
2025-09-15 12:45 ` Christian Brauner
2025-09-11 5:05 ` [PATCH 4/6] afs_dir_search: " Al Viro
2025-09-15 12:46 ` Christian Brauner
2025-09-11 5:05 ` [PATCH 5/6] generic_ci_validate_strict_name(): constify name argument Al Viro
2025-09-15 12:46 ` Christian Brauner
2025-09-11 5:05 ` [PATCH 6/6] make it easier to catch those who try to modify ->d_name Al Viro
2025-09-15 12:46 ` Christian Brauner
2025-09-11 14:30 ` [PATCH 1/6] security_dentry_init_security(): constify qstr argument Casey Schaufler
2025-09-11 20:54 ` Paul Moore [this message]
2025-09-15 12:45 ` Christian Brauner
2025-09-11 5:59 ` [PATCHES] simple part of ->d_name stuff David Howells
2025-09-11 16:56 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b042d4c28324441644cfd8e3d7733477@paul-moore.com \
--to=paul@paul-moore.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=neil@brown.name \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox