From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ECA83B798; Wed, 8 May 2024 07:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715154574; cv=none; b=OQbHT9mSNWz9uOkAhmH8FXbJAZDAZTlhLS9/yESoJDQIKyX3Al0OUdLT/B8s+4hY6sdgHO7rZhpbXY6BgA6XMQAp9eGWq8cFYVXqJIJhsRCOsLzgWVjGrf2Atp0ZxZS40onMtt9tN4XK4TFvgUX872cMF6o6SM5CEr4/aX4HB8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715154574; c=relaxed/simple; bh=8PWy0ITa9jnxFTKoYDWtuSImZrTYjBMlQF9GPAuUOBg=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=PCBjnEBjgU2GldwgR9iqDt5HjsVABstIYIzek0gTOR/AZPjVnFC92wqQRpUoVaCpoNj5or5vtwIjsgiMiWpRaF6zvpgw/Jx4Z1yf12a9iA0CSKT3Ht9o7KFiS3cLgEDBOGFhFCWn5yWvDdTcqExeDV8ekG34+oaFgxYz4CDGGsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=KEvnbxqA; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="KEvnbxqA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1715154571; bh=8PWy0ITa9jnxFTKoYDWtuSImZrTYjBMlQF9GPAuUOBg=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=KEvnbxqA5HD2jB+VWvKwvG3YXfqUotT4Bkl4uQH0q0oK5VnhjF6MO+MqerATU5/RC Y+BjpS26VndPgn5vG9cvR9At8ZpJqih78Hh4swgTcASkb6HWUxS8yKkW5N+uvz+Z44 8RPq70iB/IBhOsV1lHkcHxdcS/mG/mbr07OehUIEFfl/TyKigIhjfBDyfWr6Da+wFb rLQshr8T7f94AMbl8DJYky2cGhgU2ftJvta1aJNxTlsOeO7Ql44aESIlmjXFGyEu4B oRVKyoEMrmhYjlpMS39FYiJT3aLeyURKpfKSjjAVOlYRIiz7EniNgjtumQmcLWaWE+ cWezKmvFYEKtA== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 428403782163; Wed, 8 May 2024 07:49:04 +0000 (UTC) Message-ID: Date: Wed, 8 May 2024 12:49:23 +0500 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2 2/5] selftests/sgx: Include KHDR_INCLUDES in Makefile To: Edward Liaw , shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-3-edliaw@google.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240507214254.2787305-3-edliaw@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/8/24 2:38 AM, Edward Liaw wrote: > Add KHDR_INCLUDES to the CFLAGS to pull in the kselftest harness > dependencies (-D_GNU_SOURCE). > > Also, remove redefinitions of _GNU_SOURCE in the source code. > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang@intel.com > Signed-off-by: Edward Liaw Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/sgx/Makefile | 2 +- > tools/testing/selftests/sgx/sigstruct.c | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile > index 867f88ce2570..26ea30fae23c 100644 > --- a/tools/testing/selftests/sgx/Makefile > +++ b/tools/testing/selftests/sgx/Makefile > @@ -12,7 +12,7 @@ OBJCOPY := $(CROSS_COMPILE)objcopy > endif > > INCLUDES := -I$(top_srcdir)/tools/include > -HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC > +HOST_CFLAGS := -Wall -Werror $(KHDR_INCLUDES) -g $(INCLUDES) -fPIC > HOST_LDFLAGS := -z noexecstack -lcrypto > ENCL_CFLAGS += -Wall -Werror -static-pie -nostdlib -ffreestanding -fPIE \ > -fno-stack-protector -mrdrnd $(INCLUDES) > diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c > index d73b29becf5b..200034a0fee5 100644 > --- a/tools/testing/selftests/sgx/sigstruct.c > +++ b/tools/testing/selftests/sgx/sigstruct.c > @@ -1,7 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* Copyright(c) 2016-20 Intel Corporation. */ > > -#define _GNU_SOURCE > #include > #include > #include -- BR, Muhammad Usama Anjum