From: Mimi Zohar <zohar@linux.ibm.com>
To: Xiu Jianfeng <xiujianfeng@huawei.com>,
dmitry.kasatkin@gmail.com, paul@paul-moore.com,
jmorris@namei.org, serge@hallyn.com
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] evm: Support small xattr in dump_security_xattr()
Date: Wed, 18 Jan 2023 15:23:43 -0500 [thread overview]
Message-ID: <ba437ae5bd782ec2a6a8351f4c667aa16014af97.camel@linux.ibm.com> (raw)
In-Reply-To: <20221226102419.16189-1-xiujianfeng@huawei.com>
Hi Xiu,
Thank you for cleaning up the code. The purpose of this patch is to
remove code duplication. Perhaps rename the patch to "evm: call
dump_security_xattr() in all cases to remove code duplication".
On Mon, 2022-12-26 at 18:24 +0800, Xiu Jianfeng wrote:
> Currently the debug function of dumping xattr is splited into two parts,
> when the length of xattr is less than 64 bytes, it uses pr_debug()
> directly. Merge it into dump_security_xattr() to simplify the code, no
> functional changes here.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Please reword the patch description in terms of removing code
duplication.
--
thanks,
Mimi
prev parent reply other threads:[~2023-01-18 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 10:24 [PATCH -next] evm: Support small xattr in dump_security_xattr() Xiu Jianfeng
2023-01-18 20:23 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba437ae5bd782ec2a6a8351f4c667aa16014af97.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).