From: kgold@linux.vnet.ibm.com (Ken Goldman)
To: linux-security-module@vger.kernel.org
Subject: [tpmdd-devel] [PATCH] tpm: consolidate the TPM startup code
Date: Tue, 20 Jun 2017 16:58:19 -0400 [thread overview]
Message-ID: <ba8acc37-f751-ddbf-48a0-e5ece6cecbd2@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170620193152.GA3368@obsidianresearch.com>
On 6/20/2017 3:31 PM, Jason Gunthorpe wrote:
>>
>> +#define TPM_ORD_STARTUP 153 +#define TPM_ST_CLEAR 1
>
> We should really have a tpm1.h and tpm2.h that has all these various
> constants and things instead of open coding them randomly all over..
While you're doing that, perhaps put the ordinal numbers in hex. The
TPM 1.2 spec uses both hex and decimal, but TPM 2.0 uses hex.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-06-20 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 18:13 [PATCH] tpm: consolidate the TPM startup code Jarkko Sakkinen
2017-06-20 19:31 ` Jason Gunthorpe
2017-06-20 20:55 ` Jarkko Sakkinen
2017-06-20 21:25 ` Stefan Berger
2017-06-20 21:32 ` Jarkko Sakkinen
2017-06-20 21:38 ` Jarkko Sakkinen
2017-06-20 22:16 ` Stefan Berger
2017-06-20 21:46 ` Jarkko Sakkinen
2017-06-20 20:58 ` Ken Goldman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba8acc37-f751-ddbf-48a0-e5ece6cecbd2@linux.vnet.ibm.com \
--to=kgold@linux.vnet.ibm.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).