Linux Security Modules development
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Mimi Zohar <zohar@linux.ibm.com>, linux-security-module@vger.kernel.org
Cc: Matthew Garrett <mjg59@google.com>
Subject: Re: [PATCH] ima: remove CREDS_CHECK fall through
Date: Thu, 31 Jan 2019 12:08:43 -0600	[thread overview]
Message-ID: <bfd05ed8-de94-b484-9cf8-d02900904eb8@embeddedor.com> (raw)
In-Reply-To: <1548957686-534-1-git-send-email-zohar@linux.ibm.com>


Great!

Thanks for reviewing this, Mimi.

On 1/31/19 12:01 PM, Mimi Zohar wrote:
> This patch fixes the CREDS_CHECK fall through as annotated in the
>  "security mark expected switch fall-throughs" patch.
> 
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Matthew Garrett <mjg59@google.com>

Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

> ---
>  security/integrity/ima/ima_appraise.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
> index a2baa85ea2f5..5fb7127bbe68 100644
> --- a/security/integrity/ima/ima_appraise.c
> +++ b/security/integrity/ima/ima_appraise.c
> @@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,
>  		break;
>  	case CREDS_CHECK:
>  		iint->ima_creds_status = status;
> +		break;
>  	case FILE_CHECK:
>  	case POST_SETATTR:
>  		iint->ima_file_status = status;
> 

  reply	other threads:[~2019-01-31 18:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31 18:01 [PATCH] ima: remove CREDS_CHECK fall through Mimi Zohar
2019-01-31 18:08 ` Gustavo A. R. Silva [this message]
2019-01-31 21:26 ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfd05ed8-de94-b484-9cf8-d02900904eb8@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mjg59@google.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox