From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FE4EEAA62 for ; Thu, 14 Sep 2023 19:27:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237683AbjINT1f (ORCPT ); Thu, 14 Sep 2023 15:27:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230311AbjINT1e (ORCPT ); Thu, 14 Sep 2023 15:27:34 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F38B26AB for ; Thu, 14 Sep 2023 12:27:30 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-770819c1db6so88108085a.2 for ; Thu, 14 Sep 2023 12:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1694719649; x=1695324449; darn=vger.kernel.org; h=in-reply-to:references:subject:to:from:message-id:date:from:to:cc :subject:date:message-id:reply-to; bh=LgN4WCvEJ8wWXRweLBdinmd4ZI7NWvgRKKEqbKZQ8K4=; b=ObH4GV6HWcaqilG+6j8/TWFkjrGRr5BIQ5N0mLEhnBmfVym3SYgxW+m1GOdw6DB5AL 6llW30QDiyYb2ojOlhhwAC8xSTnkm6WGJzqI1pwD/s2UNp/hYG38gwLPNRiNVI6tiLh/ W3eOMVVANlesdZEG0ATsj31iMPDXro73/Dm2HifMjhIbnXUOknTlRjT/bVf49D0mzstl aMMaewB84f/Wl4ySr8BqCe8OjrblFpkhkcGnOA8qr+gUQ2xjH7Yth8eMghs3rLu8o/wy X58uk0J/kxCm83Wl2R08U8DUxkfBs0jgcNfqMe1ekq/1926bOk86OypgdRAIj+T/PwWj Ayrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694719649; x=1695324449; h=in-reply-to:references:subject:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LgN4WCvEJ8wWXRweLBdinmd4ZI7NWvgRKKEqbKZQ8K4=; b=cNQ6qetfJ24SCQdYSGo6HDGRSWpRiDIWp0N34vGPbL/GXH6Td7V7Xq7XeLINL4/BJL PYNnk9MZGoHeYwPn73+iL/sOZq6X8NAgMQT0qfEknYU02oNktRMc44bub3C8jYu2U9Ge Z8kvf5TTR7RKXChWVvP4FqOHjyUlRbWiLwruJuP5z7YAR6To/x+CcP9Rw4VCZitFTgRA vpycpIlwczt+qVxm/9+/hVpMEBX5fyFLAKzQO8HwFfWd4jGaS23YwqLjcTRCt/SUkJVG KbMpXc1cBbyhah00i8dAc6JexUJe4j72MbD4ZBfBhawHT0JVbFvhnG5+WfjIwi4P0OAb r1GQ== X-Gm-Message-State: AOJu0YyvpSQRY01x+tGQ/Ih5m6J7GM8pfeAuJ3Lhn2U2xnKzDRELIdGa JNkFiL7MqLoPqEoSLxAn/Wbs X-Google-Smtp-Source: AGHT+IH/m5H1VoxPInjdFLJZV1oHAFDb0GkezDRGraHnDv5FGgIiQcSe7t9i8flET4V69d2gupot8Q== X-Received: by 2002:a05:620a:d82:b0:76f:1eac:e720 with SMTP id q2-20020a05620a0d8200b0076f1eace720mr6189920qkl.25.1694719649320; Thu, 14 Sep 2023 12:27:29 -0700 (PDT) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id m10-20020ae9e00a000000b0076f35d17d06sm684548qkk.69.2023.09.14.12.27.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 12:27:28 -0700 (PDT) Date: Thu, 14 Sep 2023 15:27:28 -0400 Message-ID: From: Paul Moore To: Khadija Kamran , John Johansen , James Morris , "Serge E. Hallyn" , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Smalley , Eric Paris , selinux@vger.kernel.org, Kentaro Takeda , Tetsuo Handa , ztarkhani@microsoft.com, alison.schofield@intel.com Subject: Re: [PATCH] lsm: constify 'bprm' parameter in security_bprm_committed_creds() References: In-Reply-To: Precedence: bulk List-ID: On Aug 23, 2023 Khadija Kamran wrote: > > Three LSMs register the implementations for the 'bprm_committed_creds()' > hook: AppArmor, SELinux and tomoyo. Looking at the function > implementations we may observe that the 'bprm' parameter is not changing. > > Mark the 'bprm' parameter of LSM hook security_bprm_committed_creds() as > 'const' since it will not be changing in the LSM hook. > > Signed-off-by: Khadija Kamran > --- > include/linux/lsm_hook_defs.h | 2 +- > include/linux/security.h | 4 ++-- > security/apparmor/lsm.c | 2 +- > security/security.c | 2 +- > security/selinux/hooks.c | 2 +- > security/tomoyo/tomoyo.c | 2 +- > 6 files changed, 7 insertions(+), 7 deletions(-) Merged into lsm/next, thanks! -- paul-moore.com