From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua2-f12.google.com (mail-ua2-f12.google.com [74.125.226.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD5653977C for ; Tue, 22 Sep 2026 12:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.226.204 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790080804; cv=none; b=aPlSJjjnpigdhxB+z12169yHh232IQtn1aED26va9fx39C/9SUQXBPRxW7AMBG67Si/8hyRbw5ykKU6T95uevewoSKqQ98gUTeZGH/TpDFjLaEsF45GXglTa0RRb0ZGSTLOPEVDhrj5BEea3ay37bklCp+gRAZD6JMKHhWXvdQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790080804; c=relaxed/simple; bh=wFmJBrwWil7bpAeYIpoN4GzUL1HvXOt5ldn6IIIiFHY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M6Vul1G8kCk9QCc6ZAwk03kmzGNGFX2gAEshghWyARzraS7X2qQNefpFW4cFXc1GiyFmsKN1nT8hkWVJiz2rsR9/WPpwpm5Y19OyTBdfqSmJNnx0DCh2khKA6ETGfAwZLwlNxRHqtiV+qbX5hA4E9G8hsO/F9EMYUM8gy1NAGTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org; spf=pass smtp.mailfrom=ieee.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b=O2oXCldz; arc=none smtp.client-ip=74.125.226.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ieee.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="O2oXCldz" Received: by mail-ua2-f12.google.com with SMTP id a1e0cc1a2514c-97e7c8c8602so1828014241.0 for ; Tue, 22 Sep 2026 05:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1790080799; x=1790685599; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=o9blDfaIlaDE7zWOzf7sAkl81n8mIgiGQIMLz8R8dVg=; b=O2oXCldzJ3LpA4QHBbXInqG6gPFkiSS8IpezgH8R+ZrmCNrQGw2qZ3cz2HJXPR/LD3 nDnwu+h/q1ydJlARyj62co9tTwdWIgt6A4ziEIgZPoWy6ktNQVyLZgBsOE9UYoUt4d3f ApfWcUtfyoMebnbxzEyQSfJL5IYMdQPZlYtb0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790080799; x=1790685599; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o9blDfaIlaDE7zWOzf7sAkl81n8mIgiGQIMLz8R8dVg=; b=rm6bS9NHNV+faEnocy2jyTGJ0+mo8t2r5cFKXRif3GdRwRWFcbQ7eHk5i2L7IndRoV nkvmoC8uDqZQT5Hv3IQ15xdIAWj+n2W4PwpubheoCPLFOIQNg+eQeMtAvD+o8ToPb51t Hfu7wVg8Zi9FTIypw88cAlsTVRnKo1oi9QpUDyEds9Qi94IrU2NnvgCov90xOnAYA4U5 Zq3+Pkuuc8awL2IOLYTI4Y0eZBZYWRfHZCyBH/6TzbxUC3rDr7M4i6KxSnfSLKKIXzW8 GDqblZX96IbWnDF4nJXozMFHfSJf7Yh0LysdKzuHZO/9xC6KV8rGIc9lYDR+lTaS1Kug Sy7g== X-Forwarded-Encrypted: i=1; AKwUvBym+op4m6vKKYaFqpnGgkNjYq0Vs10bakNuoBr2995T2WEadTvzMKV9jX9H9jiJBykpmL4ThveJ697iP3hNeDewZdoEmO0=@vger.kernel.org X-Gm-Message-State: AFuF++maqhSipyEEelbF8S0+wTWGYBPF+uLhylRjp1yUHKdbJ7Soo7pK Eiv8NC5vBRGmL/8Aw/wb74inkWrd+Pq9dDaa3qJBEJfrIVDW/rBEO/EuFCnUR8hDdQ== X-Gm-Gg: AYBFou3k5z5rMfT1Yve2mdQWBMfe7LWgbMrnef5c48WjKX4wPLcOHfTKB8cbpCZt52e OF+BwtVC82PMTxsTnE6KhU3AgqGsKMcCF33FiIis+KclUUz38RUQNIZOxQZF9/DH24lLdVeozf/ 8za62EUgv9enltnvSl17u9AyRoWK+NRb6VrzfybcoRtNQw0JAd5nv+n0X//deRfxQz3JT7DQ/ab sEbdBpc+YOBbb52MxtG4YnfQmODlWdv+Rr+FWzlHEBjAP9kdcZBFpNSxQ80YJc1OSP/gQS1Aj+R 6WuCmwOYz3WxLUSHXW4nrcYd/2nGIcthGX28/vJdNAPuS6XR3fcaiB7mYijSFDZitujOMLtoRgL dnsE++LZjB16Hz+W9hEDzqrDhZ3KhpWBDiAJVbwiNGtq0ql8JhqD5lQVYOpRcQLh4cmZhBB+DV2 aM/14o+KUIw7LWMvHJllqxUVlnTuIiM3kKSBUhZgYBRz/ufPb6yodqpeLSScumajGHvJWjtNISm 8WH X-Received: by 2002:a05:6122:e22b:b0:5c9:a60c:2736 with SMTP id 71dfb90a1353d-5c9b598e442mr8405960e0c.14.1790080799199; Tue, 22 Sep 2026 05:39:59 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.googlemail.com with ESMTPSA id 6a1803df08f44-91402535ce1sm14566906d6.48.2026.09.22.05.39.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2026 05:39:53 -0700 (PDT) Message-ID: Date: Tue, 22 Sep 2026 07:39:47 -0500 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] umh, treewide: Explicitly include linux/umh.h where needed To: Petr Pavlu , Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Philipp Reisner , Lars Ellenberg , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , Jens Axboe , Johan Hovold , Alex Elder , Greg Kroah-Hartman , "Rafael J. Wysocki" , Michal Januszewski , Helge Deller , Alexander Viro , Christian Brauner , Jan Kara , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Mark Fasheh , Joel Becker , Joseph Qi , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Pavel Machek , Len Brown , Andrew Morton , Danilo Krummrich , Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , Kentaro Takeda , Tetsuo Handa Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linux.dev, linux-block@vger.kernel.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev, cgroups@vger.kernel.org, linux-modules@vger.kernel.org, linux-pm@vger.kernel.org, driver-core@lists.linux.dev, bridge@lists.linux.dev, netdev@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org References: <20260911-module-include-kmod-v3-0-6ebccc3e0731@suse.com> <20260911-module-include-kmod-v3-1-6ebccc3e0731@suse.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20260911-module-include-kmod-v3-1-6ebccc3e0731@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/11/26 9:46 AM, Petr Pavlu wrote: > The usermode helper declarations were previously provided by linux/kmod.h > but commit c1f3fa2a4fde ("kmod: split off umh headers into its own file") > moved them to linux/umh.h in 2017. > > Add explicit includes of linux/umh.h to files that use usermode helpers and > remove linux/kmod.h where it is no longer needed. > > Signed-off-by: Petr Pavlu > --- > arch/x86/kernel/cpu/mce/dev-mcelog.c | 2 +- > drivers/block/drbd/drbd_nl.c | 1 + > drivers/greybus/svc_watchdog.c | 1 + For Greybus: Acked-by: Alex Elder > drivers/macintosh/windfarm_core.c | 1 + > drivers/pnp/pnpbios/core.c | 2 +- > drivers/video/fbdev/uvesafb.c | 1 + > fs/coredump.c | 2 +- > fs/nfs/cache_lib.c | 2 +- > fs/nfsd/nfs4layouts.c | 2 +- > fs/nfsd/nfs4recover.c | 1 + > fs/ocfs2/stackglue.c | 1 + > kernel/cgroup/cgroup-v1.c | 2 +- > kernel/module/kmod.c | 1 + > kernel/power/process.c | 2 +- > kernel/reboot.c | 2 +- > kernel/umh.c | 2 +- > lib/kobject_uevent.c | 2 +- > net/bridge/br_stp_if.c | 2 +- > security/keys/request_key.c | 2 +- > security/tomoyo/common.h | 2 +- > 20 files changed, 20 insertions(+), 13 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mce/dev-mcelog.c b/arch/x86/kernel/cpu/mce/dev-mcelog.c > index 053555206d81..af4e76babe7a 100644 > --- a/arch/x86/kernel/cpu/mce/dev-mcelog.c > +++ b/arch/x86/kernel/cpu/mce/dev-mcelog.c > @@ -11,7 +11,7 @@ > > #include > #include > -#include > +#include > #include > > #include "internal.h" > diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c > index b77f901fc3ef..6f5d059394b3 100644 > --- a/drivers/block/drbd/drbd_nl.c > +++ b/drivers/block/drbd/drbd_nl.c > @@ -14,6 +14,7 @@ > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include > +#include > #include > #include > #include > diff --git a/drivers/greybus/svc_watchdog.c b/drivers/greybus/svc_watchdog.c > index 16e6de5e9eff..b318eb34bcca 100644 > --- a/drivers/greybus/svc_watchdog.c > +++ b/drivers/greybus/svc_watchdog.c > @@ -7,6 +7,7 @@ > > #include > #include > +#include > #include > #include > . . .