* [PATCH -next] LSM: Make some functions static
@ 2019-01-16 5:33 YueHaibing
2019-01-16 5:45 ` YueHaibing
0 siblings, 1 reply; 6+ messages in thread
From: YueHaibing @ 2019-01-16 5:33 UTC (permalink / raw)
To: jmorris, serge; +Cc: linux-kernel, linux-security-module, YueHaibing
Fix the follow sparse warning:
security/security.c:533:5: warning: symbol 'lsm_task_alloc' was not declared. Should it be static?
security/security.c:554:5: warning: symbol 'lsm_ipc_alloc' was not declared. Should it be static?
security/security.c:575:5: warning: symbol 'lsm_msg_msg_alloc' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
security/security.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/security/security.c b/security/security.c
index 9a98c52..750d3f3 100644
--- a/security/security.c
+++ b/security/security.c
@@ -530,7 +530,7 @@ int lsm_inode_alloc(struct inode *inode)
*
* Returns 0, or -ENOMEM if memory can't be allocated.
*/
-int lsm_task_alloc(struct task_struct *task)
+static int lsm_task_alloc(struct task_struct *task)
{
if (blob_sizes.lbs_task == 0) {
task->security = NULL;
@@ -551,7 +551,7 @@ int lsm_task_alloc(struct task_struct *task)
*
* Returns 0, or -ENOMEM if memory can't be allocated.
*/
-int lsm_ipc_alloc(struct kern_ipc_perm *kip)
+static int lsm_ipc_alloc(struct kern_ipc_perm *kip)
{
if (blob_sizes.lbs_ipc == 0) {
kip->security = NULL;
@@ -572,7 +572,7 @@ int lsm_ipc_alloc(struct kern_ipc_perm *kip)
*
* Returns 0, or -ENOMEM if memory can't be allocated.
*/
-int lsm_msg_msg_alloc(struct msg_msg *mp)
+static int lsm_msg_msg_alloc(struct msg_msg *mp)
{
if (blob_sizes.lbs_msg_msg == 0) {
mp->security = NULL;
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] LSM: Make some functions static
2019-01-16 5:33 [PATCH -next] LSM: Make some functions static YueHaibing
@ 2019-01-16 5:45 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-01-16 5:45 UTC (permalink / raw)
To: jmorris, serge; +Cc: linux-kernel, linux-security-module
Pls ignore this duplicated patch.
On 2019/1/16 13:33, YueHaibing wrote:
> Fix the follow sparse warning:
>
> security/security.c:533:5: warning: symbol 'lsm_task_alloc' was not declared. Should it be static?
> security/security.c:554:5: warning: symbol 'lsm_ipc_alloc' was not declared. Should it be static?
> security/security.c:575:5: warning: symbol 'lsm_msg_msg_alloc' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> security/security.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/security/security.c b/security/security.c
> index 9a98c52..750d3f3 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -530,7 +530,7 @@ int lsm_inode_alloc(struct inode *inode)
> *
> * Returns 0, or -ENOMEM if memory can't be allocated.
> */
> -int lsm_task_alloc(struct task_struct *task)
> +static int lsm_task_alloc(struct task_struct *task)
> {
> if (blob_sizes.lbs_task == 0) {
> task->security = NULL;
> @@ -551,7 +551,7 @@ int lsm_task_alloc(struct task_struct *task)
> *
> * Returns 0, or -ENOMEM if memory can't be allocated.
> */
> -int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> +static int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> {
> if (blob_sizes.lbs_ipc == 0) {
> kip->security = NULL;
> @@ -572,7 +572,7 @@ int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> *
> * Returns 0, or -ENOMEM if memory can't be allocated.
> */
> -int lsm_msg_msg_alloc(struct msg_msg *mp)
> +static int lsm_msg_msg_alloc(struct msg_msg *mp)
> {
> if (blob_sizes.lbs_msg_msg == 0) {
> mp->security = NULL;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -next] LSM: Make some functions static
@ 2019-01-16 5:44 Wei Yongjun
2019-01-18 19:40 ` James Morris
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wei Yongjun @ 2019-01-16 5:44 UTC (permalink / raw)
To: James Morris, Serge E. Hallyn, Casey Schaufler
Cc: Wei Yongjun, linux-security-module, kernel-janitors
Fixes the following sparse warnings:
security/security.c:533:5: warning:
symbol 'lsm_task_alloc' was not declared. Should it be static?
security/security.c:554:5: warning:
symbol 'lsm_ipc_alloc' was not declared. Should it be static?
security/security.c:575:5: warning:
symbol 'lsm_msg_msg_alloc' was not declared. Should it be static?
Fixes: f4ad8f2c4076 ("LSM: Infrastructure management of the task security")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
security/security.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/security/security.c b/security/security.c
index 9a98c52..750d3f3 100644
--- a/security/security.c
+++ b/security/security.c
@@ -530,7 +530,7 @@ int lsm_inode_alloc(struct inode *inode)
*
* Returns 0, or -ENOMEM if memory can't be allocated.
*/
-int lsm_task_alloc(struct task_struct *task)
+static int lsm_task_alloc(struct task_struct *task)
{
if (blob_sizes.lbs_task == 0) {
task->security = NULL;
@@ -551,7 +551,7 @@ int lsm_task_alloc(struct task_struct *task)
*
* Returns 0, or -ENOMEM if memory can't be allocated.
*/
-int lsm_ipc_alloc(struct kern_ipc_perm *kip)
+static int lsm_ipc_alloc(struct kern_ipc_perm *kip)
{
if (blob_sizes.lbs_ipc == 0) {
kip->security = NULL;
@@ -572,7 +572,7 @@ int lsm_ipc_alloc(struct kern_ipc_perm *kip)
*
* Returns 0, or -ENOMEM if memory can't be allocated.
*/
-int lsm_msg_msg_alloc(struct msg_msg *mp)
+static int lsm_msg_msg_alloc(struct msg_msg *mp)
{
if (blob_sizes.lbs_msg_msg == 0) {
mp->security = NULL;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] LSM: Make some functions static
2019-01-16 5:44 Wei Yongjun
@ 2019-01-18 19:40 ` James Morris
2019-01-18 19:44 ` Casey Schaufler
2019-01-18 19:47 ` James Morris
2 siblings, 0 replies; 6+ messages in thread
From: James Morris @ 2019-01-18 19:40 UTC (permalink / raw)
To: Wei Yongjun
Cc: Serge E. Hallyn, Casey Schaufler, linux-security-module,
kernel-janitors
On Wed, 16 Jan 2019, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> security/security.c:533:5: warning:
> symbol 'lsm_task_alloc' was not declared. Should it be static?
> security/security.c:554:5: warning:
> symbol 'lsm_ipc_alloc' was not declared. Should it be static?
> security/security.c:575:5: warning:
> symbol 'lsm_msg_msg_alloc' was not declared. Should it be static?
>
> Fixes: f4ad8f2c4076 ("LSM: Infrastructure management of the task security")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> security/security.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Casey, please review these fixes for your patchset.
> diff --git a/security/security.c b/security/security.c
> index 9a98c52..750d3f3 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -530,7 +530,7 @@ int lsm_inode_alloc(struct inode *inode)
> *
> * Returns 0, or -ENOMEM if memory can't be allocated.
> */
> -int lsm_task_alloc(struct task_struct *task)
> +static int lsm_task_alloc(struct task_struct *task)
> {
> if (blob_sizes.lbs_task == 0) {
> task->security = NULL;
> @@ -551,7 +551,7 @@ int lsm_task_alloc(struct task_struct *task)
> *
> * Returns 0, or -ENOMEM if memory can't be allocated.
> */
> -int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> +static int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> {
> if (blob_sizes.lbs_ipc == 0) {
> kip->security = NULL;
> @@ -572,7 +572,7 @@ int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> *
> * Returns 0, or -ENOMEM if memory can't be allocated.
> */
> -int lsm_msg_msg_alloc(struct msg_msg *mp)
> +static int lsm_msg_msg_alloc(struct msg_msg *mp)
> {
> if (blob_sizes.lbs_msg_msg == 0) {
> mp->security = NULL;
>
>
>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] LSM: Make some functions static
2019-01-16 5:44 Wei Yongjun
2019-01-18 19:40 ` James Morris
@ 2019-01-18 19:44 ` Casey Schaufler
2019-01-18 19:47 ` James Morris
2 siblings, 0 replies; 6+ messages in thread
From: Casey Schaufler @ 2019-01-18 19:44 UTC (permalink / raw)
To: Wei Yongjun, James Morris, Serge E. Hallyn
Cc: linux-security-module, kernel-janitors
On 1/15/2019 9:44 PM, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> security/security.c:533:5: warning:
> symbol 'lsm_task_alloc' was not declared. Should it be static?
> security/security.c:554:5: warning:
> symbol 'lsm_ipc_alloc' was not declared. Should it be static?
> security/security.c:575:5: warning:
> symbol 'lsm_msg_msg_alloc' was not declared. Should it be static?
>
> Fixes: f4ad8f2c4076 ("LSM: Infrastructure management of the task security")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
> ---
> security/security.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/security/security.c b/security/security.c
> index 9a98c52..750d3f3 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -530,7 +530,7 @@ int lsm_inode_alloc(struct inode *inode)
> *
> * Returns 0, or -ENOMEM if memory can't be allocated.
> */
> -int lsm_task_alloc(struct task_struct *task)
> +static int lsm_task_alloc(struct task_struct *task)
> {
> if (blob_sizes.lbs_task == 0) {
> task->security = NULL;
> @@ -551,7 +551,7 @@ int lsm_task_alloc(struct task_struct *task)
> *
> * Returns 0, or -ENOMEM if memory can't be allocated.
> */
> -int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> +static int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> {
> if (blob_sizes.lbs_ipc == 0) {
> kip->security = NULL;
> @@ -572,7 +572,7 @@ int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> *
> * Returns 0, or -ENOMEM if memory can't be allocated.
> */
> -int lsm_msg_msg_alloc(struct msg_msg *mp)
> +static int lsm_msg_msg_alloc(struct msg_msg *mp)
> {
> if (blob_sizes.lbs_msg_msg == 0) {
> mp->security = NULL;
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] LSM: Make some functions static
2019-01-16 5:44 Wei Yongjun
2019-01-18 19:40 ` James Morris
2019-01-18 19:44 ` Casey Schaufler
@ 2019-01-18 19:47 ` James Morris
2 siblings, 0 replies; 6+ messages in thread
From: James Morris @ 2019-01-18 19:47 UTC (permalink / raw)
To: Wei Yongjun
Cc: Serge E. Hallyn, Casey Schaufler, linux-security-module,
kernel-janitors
On Wed, 16 Jan 2019, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> security/security.c:533:5: warning:
> symbol 'lsm_task_alloc' was not declared. Should it be static?
> security/security.c:554:5: warning:
> symbol 'lsm_ipc_alloc' was not declared. Should it be static?
> security/security.c:575:5: warning:
> symbol 'lsm_msg_msg_alloc' was not declared. Should it be static?
>
> Fixes: f4ad8f2c4076 ("LSM: Infrastructure management of the task security")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-18 19:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-16 5:33 [PATCH -next] LSM: Make some functions static YueHaibing
2019-01-16 5:45 ` YueHaibing
-- strict thread matches above, loose matches on Subject: below --
2019-01-16 5:44 Wei Yongjun
2019-01-18 19:40 ` James Morris
2019-01-18 19:44 ` Casey Schaufler
2019-01-18 19:47 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).