From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 018A4CCA47F for ; Fri, 15 Jul 2022 21:32:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231480AbiGOVcj (ORCPT ); Fri, 15 Jul 2022 17:32:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231583AbiGOVci (ORCPT ); Fri, 15 Jul 2022 17:32:38 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95B9A7BE03 for ; Fri, 15 Jul 2022 14:32:37 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id o15so6737552pjh.1 for ; Fri, 15 Jul 2022 14:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ESan9JBmRokIZHcl3xO2oQu/yLuGmLntw5PPB729yuE=; b=noo704f8mSs/qVYaE8jN+WxPasbir+fSLLjfDYmjxXB3mRTjQciOhaNH0MLTATfQ3p tsz81HvqFoe1o/XZDn7JiMENk6vpsz9WSyGoBluR7G1G2j7rYvSjgnqxRDfKDcT9tNVv UR03bucAfDQQtEp963FnmZz0FVof5GdJsrSWo3NE8HLz7KkorM63SkEElyMYS3ogLeqh TCFJC7RwMAApK91x+Qai/1UjSh1RsT0SGTVnFABUf2TUrpDHyjvr8DuTZv7rNf7QFNuY jCCXRncwlWbm6KueNqteYwvzuV7WMcClXPA13fjv86zqKN2yzKTTbcJu7EJIOqP+EEJA tq+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ESan9JBmRokIZHcl3xO2oQu/yLuGmLntw5PPB729yuE=; b=hc945aMSOmumfwCIptTLSyXptNrjYRuXnV6MBYriMiWDsHls340ZTpcJBfWCJ6seVH ihST/YSpvlJnEof4crCgwFTUFQXIPjsPR3wnB8s9iQAXE9ovu3xb+y1b26EFlB2vdZcy liJdb60nfUAIuLbnAHz1HNUDNa4Qn6wcL1KxmwCLWKwiARY8XK4RxZG+dr3i6T7MBpol 27Pe1qg0/33cf5CHbbwoVQodz0uj6/vMYg77gddTCg+P5XJLD3AhzEPIJXBIrMIRoNfM iZM5Koq3Kr21nKKcORl5X1GRifXLZgw+GMQwuTpRiLVDPLY5vjP2SDnrr8juHikh2QjM gffA== X-Gm-Message-State: AJIora9JEMKhLegNYJ4TZTdLjpBISt3REobKt4gnZkplihAuuIemRBjN 5npxuICu7hNwMMtjS7ZR8M0EYA== X-Google-Smtp-Source: AGRyM1uazsESb2FdRADBB9x052XegnOHXqVck2P43LgHiqV6DSc2FTXLWWFTWvKwKAugfS1uHWw9lA== X-Received: by 2002:a17:90b:1a8c:b0:1ef:c1b2:b2cd with SMTP id ng12-20020a17090b1a8c00b001efc1b2b2cdmr18265028pjb.190.1657920756898; Fri, 15 Jul 2022 14:32:36 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id bd3-20020a656e03000000b00419a6f3c8f5sm3577260pgb.19.2022.07.15.14.32.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jul 2022 14:32:36 -0700 (PDT) Message-ID: Date: Fri, 15 Jul 2022 15:32:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] lsm,io_uring: add LSM hooks to for the new uring_cmd file op Content-Language: en-US To: Casey Schaufler , Paul Moore Cc: Luis Chamberlain , joshi.k@samsung.com, linux-security-module@vger.kernel.org, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, a.manzanares@samsung.com, javier@javigon.com References: <20220714000536.2250531-1-mcgrof@kernel.org> <711b10ab-4ac7-e82f-e125-658460acda89@kernel.dk> <1b220ed8-c010-15f2-3bc2-6ec4b2e7532f@schaufler-ca.com> From: Jens Axboe In-Reply-To: <1b220ed8-c010-15f2-3bc2-6ec4b2e7532f@schaufler-ca.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: On 7/15/22 3:16 PM, Casey Schaufler wrote: > On 7/15/2022 1:00 PM, Jens Axboe wrote: >> I agree that it should've been part of the initial series. As mentioned >> above, I wasn't much apart of that earlier discussion in the series, and >> hence missed that it was missing. And as also mentioned, LSM isn't much >> on my radar as nobody I know uses it. > > There are well over 6 Billion systems deployed in the wild that use LSM. > Every Android device. Every Samsung TV, camera and watch. Chromebooks. > Data centers. AWS. HPC. Statistically, a system that does not use LSM is > extremely rare. The only systems that *don't* use LSM are the ones hand > configured by Linux developers for their own use. I'm not talking about systems that only I use, but I believe you that it's in wide use. Didn't mean to imply that it isn't, just that since I don't come across it in my work or the people/systems that I've worked with, it hasn't been much on my radar and nobody has asked for it. >> This will cause oversights, even >> if they are unfortunate. My point is just that no ill intent should be >> assumed here. > > I see no ill intent. And io_uring addresses an important issue. > It just needs to work for the majority of Linux systems, not just > the few that don't use LSM. Agree, and hopefully we can make sure that it does, going forward as well. -- Jens Axboe