From: "André Draszik" <andre.draszik@linaro.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Song Liu <song@kernel.org>,
bpf@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, kernel-team@meta.com,
andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev,
viro@zeniv.linux.org.uk, jack@suse.cz, kpsingh@kernel.org,
mattbobrowski@google.com, amir73il@gmail.com,
gregkh@linuxfoundation.org, tj@kernel.org,
daan.j.demeyer@gmail.com, Will McVicker <willmcvicker@google.com>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
kernel-team@android.com
Subject: Re: [PATCH v3 bpf-next 1/4] kernfs: remove iattr_mutex
Date: Thu, 03 Jul 2025 07:28:22 +0100 [thread overview]
Message-ID: <e3a974d1f7fd1ed2a631d3ddf46eceec3a386615.camel@linaro.org> (raw)
In-Reply-To: <20250702-hochmoderne-abklatsch-af9c605b57b2@brauner>
On Wed, 2025-07-02 at 14:17 +0200, Christian Brauner wrote:
> I'm folding:
>
> diff --git a/fs/kernfs/inode.c b/fs/kernfs/inode.c
> index 3c293a5a21b1..457f91c412d4 100644
> --- a/fs/kernfs/inode.c
> +++ b/fs/kernfs/inode.c
> @@ -142,9 +142,9 @@ ssize_t kernfs_iop_listxattr(struct dentry *dentry, char *buf, size_t size)
> struct kernfs_node *kn = kernfs_dentry_node(dentry);
> struct kernfs_iattrs *attrs;
>
> - attrs = kernfs_iattrs_noalloc(kn);
> + attrs = kernfs_iattrs(kn);
> if (!attrs)
> - return -ENODATA;
> + return -ENOMEM;
>
> return simple_xattr_list(d_inode(dentry), &attrs->xattrs, buf, size);
> }
>
> which brings it back to the old behavior.
Yes, that makes sense and works for me too.
Thanks Christian!
next prev parent reply other threads:[~2025-07-03 6:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 6:38 [PATCH v3 bpf-next 0/4] Introduce bpf_cgroup_read_xattr Song Liu
2025-06-23 6:38 ` [PATCH v3 bpf-next 1/4] kernfs: remove iattr_mutex Song Liu
2025-07-02 10:47 ` André Draszik
2025-07-02 12:17 ` Christian Brauner
2025-07-03 6:28 ` André Draszik [this message]
2025-08-16 5:52 ` Jan Kiszka
2025-08-19 10:05 ` Christian Brauner
2025-06-23 6:38 ` [PATCH v3 bpf-next 2/4] bpf: Introduce bpf_cgroup_read_xattr to read xattr of cgroup's node Song Liu
2025-06-23 6:38 ` [PATCH v3 bpf-next 3/4] bpf: Mark cgroup_subsys_state->cgroup RCU safe Song Liu
2025-06-23 6:38 ` [PATCH v3 bpf-next 4/4] selftests/bpf: Add tests for bpf_cgroup_read_xattr Song Liu
2025-06-23 11:03 ` [PATCH v3 bpf-next 0/4] Introduce bpf_cgroup_read_xattr Christian Brauner
2025-06-27 2:14 ` Alexei Starovoitov
2025-06-27 4:04 ` Song Liu
2025-06-27 15:59 ` Alexei Starovoitov
2025-06-27 16:20 ` Song Liu
2025-07-01 8:32 ` Christian Brauner
2025-07-01 16:23 ` Song Liu
2025-07-02 12:19 ` Christian Brauner
2025-07-01 8:31 ` Christian Brauner
2025-07-01 14:51 ` Alexei Starovoitov
2025-07-02 8:37 ` Christian Brauner
2025-06-27 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3a974d1f7fd1ed2a631d3ddf46eceec3a386615.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=amir73il@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daan.j.demeyer@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=kernel-team@android.com \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=peter.griffin@linaro.org \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).