linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>,
	corbet@lwn.net, paul@paul-moore.com, jmorris@namei.org,
	serge@hallyn.com, shuah@kernel.org, mcoquelin.stm32@gmail.com,
	alexandre.torgue@foss.st.com, mic@digikod.net
Cc: linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	bpf@vger.kernel.org, zohar@linux.ibm.com,
	dmitry.kasatkin@gmail.com, linux-integrity@vger.kernel.org,
	wufan@linux.microsoft.com, pbrobinson@gmail.com,
	zbyszek@in.waw.pl, hch@lst.de, mjg59@srcf.ucam.org,
	pmatilai@redhat.com, jannh@google.com, dhowells@redhat.com,
	jikos@kernel.org, mkoutny@suse.com, ppavlu@suse.com,
	petr.vorel@gmail.com, petrtesarik@huaweicloud.com,
	Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH v3 02/13] security: Introduce the digest_cache LSM
Date: Fri, 9 Feb 2024 15:00:44 -0800	[thread overview]
Message-ID: <e8378ba2-ccd1-48fe-973d-38986fc0716d@infradead.org> (raw)
In-Reply-To: <20240209140917.846878-3-roberto.sassu@huaweicloud.com>

Hi--

On 2/9/24 06:09, Roberto Sassu wrote:
> diff --git a/security/digest_cache/Kconfig b/security/digest_cache/Kconfig
> new file mode 100644
> index 000000000000..0c47d5151f07
> --- /dev/null
> +++ b/security/digest_cache/Kconfig
> @@ -0,0 +1,17 @@
> +# SPDX-License-Identifier: GPL-2.0
> +config SECURITY_DIGEST_CACHE
> +	bool "Digest_cache LSM"
> +	default n
> +	help
> +	   This option enables an LSM maintaining a cache of digests
> +	   (e.g. of file content or metadata).
> +
> +	   This LSM can support other kernel components in making access
> +	   control decisions.
> +

nit:  -ESTYLE.
coding-style.rst says:

Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.

> +config DIGEST_LIST_DEFAULT_PATH
> +	string
> +	default "/etc/digest_lists"
> +	help
> +	   Default directory where digest_cache LSM expects to find digest
> +	   lists.

Same comment for patch 03/13.
Same comment for patch 04/13.

-- 
#Randy

  reply	other threads:[~2024-02-09 23:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 14:09 [PATCH v3 00/13] security: digest_cache LSM Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 01/13] lib: Add TLV parser Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 02/13] security: Introduce the digest_cache LSM Roberto Sassu
2024-02-09 23:00   ` Randy Dunlap [this message]
2024-02-12  8:02     ` Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 03/13] digest_cache: Add securityfs interface Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 04/13] digest_cache: Add hash tables and operations Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 05/13] digest_cache: Populate the digest cache from a digest list Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 06/13] digest_cache: Parse tlv digest lists Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 07/13] digest_cache: Parse rpm " Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 08/13] digest_cache: Add management of verification data Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 09/13] digest_cache: Add support for directories Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 10/13] digest cache: Prefetch digest lists if requested Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 11/13] digest_cache: Reset digest cache on file/directory change Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 12/13] selftests/digest_cache: Add selftests for digest_cache LSM Roberto Sassu
2024-02-09 14:09 ` [PATCH v3 13/13] docs: Add documentation of the " Roberto Sassu
2024-02-28 17:46 ` [PATCH v3 00/13] security: " Roberto Sassu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8378ba2-ccd1-48fe-973d-38986fc0716d@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=dhowells@redhat.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=hch@lst.de \
    --cc=jannh@google.com \
    --cc=jikos@kernel.org \
    --cc=jmorris@namei.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mic@digikod.net \
    --cc=mjg59@srcf.ucam.org \
    --cc=mkoutny@suse.com \
    --cc=paul@paul-moore.com \
    --cc=pbrobinson@gmail.com \
    --cc=petr.vorel@gmail.com \
    --cc=petrtesarik@huaweicloud.com \
    --cc=pmatilai@redhat.com \
    --cc=ppavlu@suse.com \
    --cc=roberto.sassu@huawei.com \
    --cc=roberto.sassu@huaweicloud.com \
    --cc=serge@hallyn.com \
    --cc=shuah@kernel.org \
    --cc=wufan@linux.microsoft.com \
    --cc=zbyszek@in.waw.pl \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).