From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A23337BB2 for ; Fri, 19 Dec 2025 21:28:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766179734; cv=none; b=Z9lC/xe5nnr8bdb1SkinrBEfqmQm64VeuIMe0AVgvEOoGqCOYK6vg9xX4gT7JEez6D8v3hue+U933Qb5CstyrSyqTf10RGmtYdmQEtjcCZILVSWvhOARNuoFuzkfof1A9v8d8twzsdFsDEYLhAn136ZaEc28AwuD4BhL0VtLN6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766179734; c=relaxed/simple; bh=9qdyLYhk6D9KpgNEc9lTRHJNMgr66Y5zIziSEMCrXTM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AyiiP+lcKI9VoPhyOHfSNvQ/jfgazDJ5y+2ft85t7ibIJ00CQy9/hyvJIXyCEiRfZkjn6xQpOYcsk3mRCL1keDrf4W0yfOlSxmJtoLkFPs6cfXBPk0l3I3wYeU1Q18mvldexc+/VMGU0W74EK5ISND31rEEOf/Zm2NEVKonHSkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RMtyxVaH; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RMtyxVaH" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-7ba55660769so1867338b3a.1 for ; Fri, 19 Dec 2025 13:28:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766179731; x=1766784531; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9qdyLYhk6D9KpgNEc9lTRHJNMgr66Y5zIziSEMCrXTM=; b=RMtyxVaHlb4x5czCBEyOx56xfjT+RNoyzgmUIOLM8rQyyjHAn8b14RHWVg+U9yECU2 DNet9BX2LSDx+fbfhj2eagJwVgKFUN3paA/J0jVpzr17MqrPGIkC8uWMpzr25M5n/Svh riLL7VUKYl3lLur1iiIDnUxqZzSyVldJOlWErwA4BYTCmBjZa+IIIv/4tggBwnPyd5N1 4sP+EomK5LaRfaouO3drpoA8BG7gNbSc2L4KFhFCx08iZDlPsih1J+3De+KvkTA6nBjx xSBUnB9EV5NlQAOueOI5ovsh9ZrpK2mKI2rYqZMt2HvppVyMTV6Z5xJIcetFL+mvKY9C JWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766179731; x=1766784531; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9qdyLYhk6D9KpgNEc9lTRHJNMgr66Y5zIziSEMCrXTM=; b=nd2hPmP66tSBNeSbTMHc9yR1DDfErsVVdlR9z1PBDRCaHuHk3FgOR5N9OW/rLDJy37 9Hnaej0c6Qif6xN6NOXO1bhNd+uxYHOVw4elACRDOmSHoHKyC9fVpWDnTts5NBGslWdv GlaTeBl7tIE64qsbF5j8bWpnmU/5hd/UPeLFyM5wGFKqxQ9kOK2G4l1eK28tD22hzyqa XnYwKWD5SW84V/V+jrnRsRlOtM125ndypIENh6VALU7nD9ldHzZkXs2yKcwPJhu7Yx2R aZnVARWc/amA1C4HUwb6FroBJV1qXZc1cDEg5SIhw048Qt5/CZDJ18u70mz6XpIL2+B9 X1fQ== X-Forwarded-Encrypted: i=1; AJvYcCXS23Qwdidv1Oxe5pWnt7hkophqF1rmkRyzXsp+V3/nD3P/V7dE6ni5TWUT1gQTA3PK8lUbTBi7vNURS20L98rmR7P/5Sg=@vger.kernel.org X-Gm-Message-State: AOJu0YyiE9RwinBTsFSOb0Lw8LuQiFOMKRym/Kj2I/ok9Y+76MFLA9Q+ K0qNhBftMJqcGXKDUBTZEyqeaBat+ESWl47icXGi+nvE5S1jd75LBMqB X-Gm-Gg: AY/fxX4ZA/yTrQcAhkkoYIQE7TiyHka+Fqbn5aSg/LWGUOq7EKSugFTfSzq6FlHuFFt NmtTwzrEnjdmdoQEMjm5wckXzN5ZPfvBpXLMUc7MnYZP+jQHKYm7qWu+sTlIKifStM/HRu9WYds 0Y0/zS2J5nnih9G9ftcK5Kebr/dQGxyRvQdRfZzmEHoPWgy7g1kUZh2E5pFRKmZuupOSl3+m2ft MdyvqBcmAOzOaaMj1SrQCA8Gx/a+OdREdFCotkfCZ2hR1ccI8jbCyaHqdolbufNJFzoKzjOPXai H9p3yntRlNs8iamgPQzsTJIXQ/k8+gPfJ/kouX1iUDy18bS2BE+O0vD5YRcUX9umX7BimR7D1fs 0grcDYs6MjyplXdlHulaPLcfBERGEB6tRGCLkQIZmwKNCJ0HLVTLm+6bPLqMYsOAV89ah7SeVX6 FNKQ1IYsg1qdvpxsanMDWqScD/yOVaAzHZzAKmBw5QmuRmSNzejkd0CzoOEiq69k8bAmeEC3gpE 4FgXtIJ9kLdIW8Y+HYbvis+SMArtbb1/2BCoGb8pqv83fW7+G/z+ws6NV4i1OESNtoocoisQ2Kd lUA= X-Google-Smtp-Source: AGHT+IFntC97OMoIKW8iak4Csi+Sa/wJHZS2qz46SkDovenEuEnw3BILL/ha2LHm12T/rhrLMeYBbA== X-Received: by 2002:a05:7022:6988:b0:119:e56b:91ed with SMTP id a92af1059eb24-121722e01c2mr4354548c88.30.1766179731046; Fri, 19 Dec 2025 13:28:51 -0800 (PST) Received: from ?IPV6:2a00:79e0:2e7c:8:5874:79f3:80da:a7a3? ([2a00:79e0:2e7c:8:5874:79f3:80da:a7a3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1217254cd77sm12305503c88.14.2025.12.19.13.28.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 13:28:50 -0800 (PST) Message-ID: Date: Fri, 19 Dec 2025 14:28:48 -0700 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 07/36] lockdep: Annotate lockdep assertions for context analysis To: Marco Elver Cc: Peter Zijlstra , Boqun Feng , Ingo Molnar , Will Deacon , "David S. Miller" , Luc Van Oostenryck , Chris Li , "Paul E. McKenney" , Alexander Potapenko , Arnd Bergmann , Christoph Hellwig , Dmitry Vyukov , Eric Dumazet , Frederic Weisbecker , Greg Kroah-Hartman , Herbert Xu , Ian Rogers , Jann Horn , Joel Fernandes , Johannes Berg , Jonathan Corbet , Josh Triplett , Justin Stitt , Kees Cook , Kentaro Takeda , Lukas Bulwahn , Mark Rutland , Mathieu Desnoyers , Miguel Ojeda , Nathan Chancellor , Neeraj Upadhyay , Nick Desaulniers , Steven Rostedt , Tetsuo Handa , Thomas Gleixner , Thomas Graf , Uladzislau Rezki , Waiman Long , kasan-dev@googlegroups.com, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-sparse@vger.kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, rcu@vger.kernel.org References: <20251219154418.3592607-1-elver@google.com> <20251219154418.3592607-8-elver@google.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/25 2:16 PM, Marco Elver wrote: > It's basically an escape hatch to defer to dynamic analysis where the > limits of the static analysis are reached. That's not how lockdep_assert_held() is used in the kernel. This macro is more often than not used to document assumptions that can be verified at compile time. This patch seems like a step in the wrong direction to me because it *suppresses* compile time analysis compile-time analysis is useful. I think that this patch either should be dropped or that the __assume() annotations should be changed into __must_hold() annotations. Bart.