From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 376A710A17 for ; Fri, 17 May 2024 03:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715917629; cv=none; b=IU/X2f6K14EutnDPrCYnOWRotv/W5la8ctyjsUSNrLXB0kJ5Bw+axl1N5dr3q6v/HzAp4ix2kQ0sK+RiI5wAre0GQZX/rOFEN2CIiX0kpjOKYcweTsH0ljnipNKOa9mGpEjfivc6mPrg7AQhs5YpiNYAJEL/O4RCFuoPKHk4rK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715917629; c=relaxed/simple; bh=60WJPyunhwRDxdqK0jmaca+G8J/J7dfoT/EsRzkUIOM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TFbN5FwGnV+CYbxh6FaqkrgffLtPth9+gE4YEeHPxjWDLSPZnT9vid7i/4aKhPWAmeWGEcJU+puLPuzJr+4zwWbR2V/PQM8PuWaz5+TJG848SE+JA++Hj1jiYtmxTkcgJIrZ4ltVDJHbivAx/Pn6IghgdtktZxj8CNeDhBy+VKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KkFX2Qdv; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KkFX2Qdv" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7e1b520812fso13101539f.1 for ; Thu, 16 May 2024 20:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1715917627; x=1716522427; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yDlOiioY4qBdeDaBJ3EMBjG9W4k3e+q2KQuwlwFm/Wg=; b=KkFX2Qdvuhzl5EaGH5xkrhb0yT1vguDmkATYGJXXzKL+60FaUrp0rGhbJAIzha2c8Y +HEYSfsGATA7i7Rcq8GakJDptzuDZE7S2ciBMIyojTlAnot1ibQnXvuSgmCpVNmzm6Pv oG5WBKMzyD2u4NSVuQlS6NsJTg1ucs84pQE9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715917627; x=1716522427; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yDlOiioY4qBdeDaBJ3EMBjG9W4k3e+q2KQuwlwFm/Wg=; b=YtU2qCD4MuimeN/VvV6ZunPhpP69/aT2ejmsuXafRuuJval9uGe1rUBBdWrTm6bU3J SLTkEbtcX6sEkZmQnA4HhhTY+Gg39ZFVeKs7U1iWEuSfQm0Q0GSrBqOhqggkJOyGEgFM Zym7K+S/xSt8CdfqYQJnsWiLMHsc6N3NiF4fTOv1iXmrT+sold7XKlOD93SDQ9Y77NSl xvdIpRXwG+Fgcrn3IN4NFdt736FNQ8f7OU8OYoVu7ZXvywjOEuD7LpN6vQ+fGH8MtFSs V8PVgRsznsNKpE0yqR8iiorctsOwVDcexvoDFvI+nUlRYGICIJQwbh8sFcMjLTxaO0UF bdUQ== X-Forwarded-Encrypted: i=1; AJvYcCXoyLtmCPprEHOph+CG6BjO5oWxyMzkq7I4K0PoNWBez1nwrGQcpNFW19PjJ2VsHlAvQNTuF0lxXaxLysyV3aDXOcK6h393mw+8LL7TJIutE+0gCBM2 X-Gm-Message-State: AOJu0YwpkwzRmh4ubeZbYOH8NExOCwFCpG5rVYB1Qst9J+Vz4GZnKiYP b9fU9Ff9cxejGmBgwdQ5OSkTyme7WfWLQHAO/GnoYZMfnXPLUQ/zu0Ij3wTKcXs= X-Google-Smtp-Source: AGHT+IGdK6rFNtMzv/o7w6HNu0tCiqSEnlqZgL7f/KrvB7GNWi1KNGokcDBCge/J7xruX5muwQNDjQ== X-Received: by 2002:a5e:c748:0:b0:7e1:d865:e700 with SMTP id ca18e2360f4ac-7e1d865e82emr1709781039f.2.1715917627289; Thu, 16 May 2024 20:47:07 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-489376de473sm4436301173.154.2024.05.16.20.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 May 2024 20:47:06 -0700 (PDT) Message-ID: Date: Thu, 16 May 2024 21:47:05 -0600 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE To: Tejun Heo Cc: Edward Liaw , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Zefan Li , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , Shakeel Butt , Yosry Ahmed , Nhat Pham , Chengming Zhou , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Shuah Khan References: <20240510000842.410729-1-edliaw@google.com> <20240510000842.410729-9-edliaw@google.com> <9e72d97a-9a04-4423-a711-0c21c1c8b161@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/16/24 12:05, Shuah Khan wrote: > On 5/16/24 11:45, Tejun Heo wrote: >> Hello, >> >> On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote: >>> I am exploring options and leaning towards reverting the patch >>> >>> daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") >>> >>> Your amending the PR helps me if I have to send revert. I am sorry >>> for the trouble. >>> >>> I can all of them together in a second update or after the merge window >>> closes. >> >> The cgroup commit is already pulled in unfortunately. Can you please handle >> the revert and whatever's necessary to fix up the situation? I'll ask you >> what to do with selftest patches from now on. >> > > Thanks for the update. Yes I am working on fixing the situation and > will send revert for cgroup test patch as well if necessary. > > No worries. It is not a problem for you to handle cgroup test patches > in general. I will need your review anyway and letting you handle them > reduces the overhead. > > This kind of framework change causes needs to be coordinated. > I should have held back on the framework change on my part. > As mentioned in the other thread https://lore.kernel.org/linux-kselftest/24975952-b1fa-44a5-bac5-aef538ad0c09@linuxfoundation.org/T/#t I reverted the following patch and the framework change patch. https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next Will send PR to Linus this weekend. "selftests/cgroup: Drop define _GNU_SOURCE" commit c1457d9aad5ee2feafcf85aa9a58ab50500159d2 thanks, -- Shuah