From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E90D7C61DA4 for ; Tue, 14 Feb 2023 08:51:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232132AbjBNIv3 (ORCPT ); Tue, 14 Feb 2023 03:51:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232157AbjBNIvU (ORCPT ); Tue, 14 Feb 2023 03:51:20 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB51023334; Tue, 14 Feb 2023 00:51:07 -0800 (PST) Received: from lhrpeml500004.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PGFF00KpRz67NcH; Tue, 14 Feb 2023 16:46:44 +0800 (CST) Received: from [10.123.123.126] (10.123.123.126) by lhrpeml500004.china.huawei.com (7.191.163.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Tue, 14 Feb 2023 08:51:04 +0000 Message-ID: Date: Tue, 14 Feb 2023 11:51:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v9 02/12] landlock: Allow filesystem layout changes for domains without such rule type Content-Language: ru To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= CC: , , , , , , References: <20230116085818.165539-1-konstantin.meskhidze@huawei.com> <20230116085818.165539-3-konstantin.meskhidze@huawei.com> <97ff3f0f-1704-3003-fe60-d7444579e0d7@digikod.net> From: "Konstantin Meskhidze (A)" In-Reply-To: <97ff3f0f-1704-3003-fe60-d7444579e0d7@digikod.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.123.123.126] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500004.china.huawei.com (7.191.163.9) X-CFilter-Loop: Reflected Precedence: bulk List-ID: 2/10/2023 8:34 PM, Mickaël Salaün пишет: > Hi Konstantin, > > I think this patch series is almost ready. Here is a first batch of > review, I'll send more next week. > Hi Mickaёl. thnaks for the review. > > I forgot to update the documentation. Can you please squash the > following patch into this one? No problem. I will squash. Can I download this doc patch from your repo or I can use the diff below? > > > diff --git a/Documentation/userspace-api/landlock.rst > b/Documentation/userspace-api/landlock.rst > index 980558b879d6..fc2be89b423f 100644 > --- a/Documentation/userspace-api/landlock.rst > +++ b/Documentation/userspace-api/landlock.rst > @@ -416,9 +416,9 @@ Current limitations > Filesystem topology modification > -------------------------------- > > -As for file renaming and linking, a sandboxed thread cannot modify its > -filesystem topology, whether via :manpage:`mount(2)` or > -:manpage:`pivot_root(2)`. However, :manpage:`chroot(2)` calls are not > denied. > +Threads sandboxed with filesystem restrictions cannot modify filesystem > +topology, whether via :manpage:`mount(2)` or :manpage:`pivot_root(2)`. > +However, :manpage:`chroot(2)` calls are not denied. > > Special filesystems > ------------------- > > > On 16/01/2023 09:58, Konstantin Meskhidze wrote: >> From: Mickaël Salaün >> >> Allow mount point and root directory changes when there is no filesystem >> rule tied to the current Landlock domain. This doesn't change anything >> for now because a domain must have at least a (filesystem) rule, but >> this will change when other rule types will come. For instance, a >> domain only restricting the network should have no impact on filesystem >> restrictions. >> >> Add a new get_current_fs_domain() helper to quickly check filesystem >> rule existence for all filesystem LSM hooks. >> >> Remove unnecessary inlining. >> >> Signed-off-by: Mickaël Salaün >> --- >> >> Changes since v8: >> * Refactors get_handled_fs_accesses(). >> * Adds landlock_get_raw_fs_access_mask() helper. >> > .