From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF80CC34021 for ; Mon, 17 Feb 2020 16:10:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7686214D8 for ; Mon, 17 Feb 2020 16:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727476AbgBQQKW (ORCPT ); Mon, 17 Feb 2020 11:10:22 -0500 Received: from mx2.suse.de ([195.135.220.15]:49586 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726866AbgBQQKW (ORCPT ); Mon, 17 Feb 2020 11:10:22 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5012FBA2D; Mon, 17 Feb 2020 16:10:20 +0000 (UTC) Date: Mon, 17 Feb 2020 17:10:20 +0100 Message-ID: From: Takashi Iwai To: Ard Biesheuvel Cc: Javier Martinez Canillas , linux-efi , Joey Lee , linux-security-module Subject: Re: [PATCH] efi: Suppress spurious "Couldn't get size" error In-Reply-To: References: <20200217154549.20895-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, 17 Feb 2020 17:06:57 +0100, Ard Biesheuvel wrote: > > On Mon, 17 Feb 2020 at 16:45, Takashi Iwai wrote: > > > > The current efi code emits the error message like > > Couldn't get size: 0x800000000000000e > > on various Dell and other machines. Although the whole problem is the > > buggy firmware, showing this as an error level is rather annoying, as > > the error message appears over the boot splash. Basically this is the > > result of missing entry and we have no explicit way to fix it for such > > a firmware problem, the error message may be suppressed. > > > > This patch changes the error print condition and suppresses the error > > message if status is EFI_NOT_FOUND. It's a partial patch from the > > more comprehensive one Joey Lee submitted in the past. > > > > Link: https://lore.kernel.org/linux-efi/20190322103350.27764-2-jlee@suse.com/ > > Cc: Joey Lee > > Signed-off-by: Takashi Iwai > > Hello Takashi, > > Javier sent a more comprehensive fix for this today. The problem is > not buggy firmware, but buggy kernel :-) > (the code assumes that all systems boot via shim, and that certain EFI > variables are therefore guaranteed to exist, which is not the case) > > https://lore.kernel.org/linux-efi/CAKv+Gu-a5Bo9i=K55pa3jEXRq-u5JYVGp1jFEE=UY5B=6eUkRQ@mail.gmail.com Awesome, then please scratch mine. Thanks! Takashi