From: sashiko-bot@kernel.org
Cc: linux-security-module@vger.kernel.org
Subject: Re: [PATCH] apparmor: fix double d_instantiate() in ns_mkdir_op()
Date: Mon, 09 Nov 2026 03:35:30 +0000 [thread overview]
Message-ID: <sashiko-outbox-204373@kernel.org> (raw)
In-Reply-To: <20261109025600.2031008-1-ranhongyun1@huawei.com>
> ns_mkdir_op() drops inode_lock for simple_pin_fs() and re-acquires it
> before instantiating the dentry. A concurrent mkdir() of the same name
> can pass the VFS negative-dentry checks in that window and also reach
> d_instantiate(), tripping BUG_ON(!hlist_unhashed(&d_alias)).
>
> Re-check that the dentry is still negative after re-acquiring inode_lock
> and return -EEXIST if a concurrent mkdir() won the race.
>
> Fixes: 4ae47f33354a ("apparmor: add mkdir/rmdir interface to manage policy namespaces")
> Signed-off-by: Ran Hongyun <ranhongyun1@huawei.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109025600.2031008-1-ranhongyun1@huawei.com?part=1
prev parent reply other threads:[~2026-11-09 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 2:56 [PATCH] apparmor: fix double d_instantiate() in ns_mkdir_op() Ran Hongyun
2026-11-09 3:35 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204373@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox