From: sashiko-bot@kernel.org
Cc: linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2 09/13] bpf: return NULL from bpf_real_data_inode() on errors
Date: Mon, 16 Nov 2026 09:51:43 +0000 [thread overview]
Message-ID: <sashiko-outbox-216654@kernel.org> (raw)
In-Reply-To: <20261116-work-ovl-d_real-v2-9-90564c4ae347@kernel.org>
> d_real() is about to be able to fail for D_REAL_DATA. So switch
> bpf_real_data_inode() from d_real_inode() to d_real_data_inode() and
> return NULL if the data can't be resolved.
>
> The kfunc is already KF_SLEEPABLE | KF_RET_NULL and its documentation
> says it may return NULL. So programs already have to deal with NULL and
> the verifier enforces that. Note that this is the caller that most
> easily ends up with a file whose data was never looked up.
> lsm.s/file_open runs before ovl_open() and lsm.s/file_receive sees
> O_PATH files passed via SCM_RIGHTS.
>
> Spell that out in the documentation.
>
> This is a no-op until d_real() can actually fail.
>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-work-ovl-d_real-v2-0-90564c4ae347@kernel.org?part=9
next prev parent reply other threads:[~2026-11-16 9:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 9:43 [PATCH v2 00/13] fs: let d_real() fail Christian Brauner
2026-11-16 9:43 ` [PATCH v2 01/13] ovl: don't warn when the lazy lowerdata lookup fails in ovl_d_real() Christian Brauner
2026-11-16 9:49 ` sashiko-bot
2026-11-16 9:43 ` [PATCH v2 02/13] fs: add d_real_data_inode() and d_real_metadata_inode() Christian Brauner
2026-11-16 9:49 ` sashiko-bot
2026-11-16 9:44 ` [PATCH v2 03/13] tracing/uprobes: handle errors from resolving the real inode Christian Brauner
2026-11-16 9:53 ` sashiko-bot
2026-11-16 9:44 ` [PATCH v2 04/13] bpf: handle errors from resolving the real inode in uprobe_multi Christian Brauner
2026-11-16 9:49 ` sashiko-bot
2026-11-16 9:44 ` [PATCH v2 05/13] selftests/bpf: handle d_real_data_inode() errors in bpf_testmod Christian Brauner
2026-11-16 9:49 ` sashiko-bot
2026-11-16 9:44 ` [PATCH v2 06/13] ima: handle errors from resolving the real inode Christian Brauner
2026-11-16 9:53 ` sashiko-bot
2026-11-16 9:44 ` [PATCH v2 07/13] ima,evm: use d_real_metadata_inode() Christian Brauner
2026-11-16 9:52 ` sashiko-bot
2026-11-16 9:44 ` [PATCH v2 08/13] ipe: handle errors from resolving the real inode Christian Brauner
2026-11-16 9:49 ` sashiko-bot
2026-11-16 9:44 ` [PATCH v2 09/13] bpf: return NULL from bpf_real_data_inode() on errors Christian Brauner
2026-11-16 9:51 ` sashiko-bot [this message]
2026-11-16 9:44 ` [PATCH v2 10/13] ovl: return the error from the lazy lowerdata lookup in ovl_d_real() Christian Brauner
2026-11-16 9:44 ` [PATCH v2 11/13] fs: remove d_real_inode() Christian Brauner
2026-11-16 9:50 ` sashiko-bot
2026-11-16 9:44 ` [PATCH v2 12/13] selftests/ftrace: add uprobe tests on overlayfs Christian Brauner
2026-11-16 9:53 ` sashiko-bot
2026-11-16 9:44 ` [PATCH v2 13/13] selftests/bpf: add uprobe_multi test on overlayfs without data Christian Brauner
2026-11-16 9:53 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216654@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox