* [PATCH 2/2] serial: samsung: Fixed wrong comparison for baudclk_rate
@ 2012-05-20 8:49 Kyoungil Kim
2012-06-20 4:28 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Kyoungil Kim @ 2012-05-20 8:49 UTC (permalink / raw)
To: linux-arm-kernel, linux-samsung-soc, linux-serial
Cc: 'Kukjin Kim', 'Alan Cox', 'Kyoungil Kim',
'Yoon'
port->baudclk_rate should be compared to the rate of port->baudclk,
because port->baudclk_rate was assigned as the rate of port->baudclk previously.
So to check that the current baudclk rate is same as previous rate,
the target of comparison sholud be the rate of port->baudclk.
Signed-off-by: Jun-Ho, Yoon <junho78.yoon@samsung.com>
Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
---
drivers/tty/serial/samsung.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 5668538..cefdd2d 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1013,10 +1013,10 @@ static int s3c24xx_serial_cpufreq_transition(struct notifier_block *nb,
* a disturbance in the clock-rate over the change.
*/
- if (IS_ERR(port->clk))
+ if (IS_ERR(port->baudclk))
goto exit;
- if (port->baudclk_rate == clk_get_rate(port->clk))
+ if (port->baudclk_rate == clk_get_rate(port->baudclk))
goto exit;
if (val == CPUFREQ_PRECHANGE) {
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 2/2] serial: samsung: Fixed wrong comparison for baudclk_rate
2012-05-20 8:49 [PATCH 2/2] serial: samsung: Fixed wrong comparison for baudclk_rate Kyoungil Kim
@ 2012-06-20 4:28 ` Kukjin Kim
2012-06-20 23:50 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2012-06-20 4:28 UTC (permalink / raw)
To: 'Kyoungil Kim', linux-arm-kernel, linux-samsung-soc,
linux-serial
Cc: 'Alan Cox', 'Yoon', gregkh
Kyoungil Kim wrote:
>
> port->baudclk_rate should be compared to the rate of port->baudclk,
> because port->baudclk_rate was assigned as the rate of port->baudclk
> previously.
> So to check that the current baudclk rate is same as previous rate,
> the target of comparison sholud be the rate of port->baudclk.
>
> Signed-off-by: Jun-Ho, Yoon <junho78.yoon@samsung.com>
> Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
(Cc'ed Greg)
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Greg, this is needed to fix the wrong comparison for baudclk_rate for
Samsung Serial.
Could you please pick this up in your fix tree?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> ---
> drivers/tty/serial/samsung.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 5668538..cefdd2d 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1013,10 +1013,10 @@ static int
> s3c24xx_serial_cpufreq_transition(struct notifier_block *nb,
> * a disturbance in the clock-rate over the change.
> */
>
> - if (IS_ERR(port->clk))
> + if (IS_ERR(port->baudclk))
> goto exit;
>
> - if (port->baudclk_rate == clk_get_rate(port->clk))
> + if (port->baudclk_rate == clk_get_rate(port->baudclk))
> goto exit;
>
> if (val == CPUFREQ_PRECHANGE) {
> --
> 1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] serial: samsung: Fixed wrong comparison for baudclk_rate
2012-06-20 4:28 ` Kukjin Kim
@ 2012-06-20 23:50 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2012-06-20 23:50 UTC (permalink / raw)
To: Kukjin Kim
Cc: 'Kyoungil Kim', linux-arm-kernel, linux-samsung-soc,
linux-serial, 'Alan Cox', 'Yoon'
On Wed, Jun 20, 2012 at 01:28:40PM +0900, Kukjin Kim wrote:
> Kyoungil Kim wrote:
> >
> > port->baudclk_rate should be compared to the rate of port->baudclk,
> > because port->baudclk_rate was assigned as the rate of port->baudclk
> > previously.
> > So to check that the current baudclk rate is same as previous rate,
> > the target of comparison sholud be the rate of port->baudclk.
> >
> > Signed-off-by: Jun-Ho, Yoon <junho78.yoon@samsung.com>
> > Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
>
> (Cc'ed Greg)
>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
>
> Greg, this is needed to fix the wrong comparison for baudclk_rate for
> Samsung Serial.
> Could you please pick this up in your fix tree?
Already there, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-20 23:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-20 8:49 [PATCH 2/2] serial: samsung: Fixed wrong comparison for baudclk_rate Kyoungil Kim
2012-06-20 4:28 ` Kukjin Kim
2012-06-20 23:50 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).