From: Jingoo Han <jg1.han@samsung.com>
To: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com>,
'Ian Abbott' <abbotti@mev.co.uk>,
'Wang YanQing' <udknight@gmail.com>,
'Stephen Chivers' <schivers@csc.com>,
'Stephen Hurd' <shurd@broadcom.com>
Subject: [PATCH 2/3] serial: 8250_pci: remove unnecessary pci_set_drvdata()
Date: Thu, 12 Sep 2013 15:33:48 +0900 [thread overview]
Message-ID: <000e01ceaf82$0a2fff10$1e8ffd30$%han@samsung.com> (raw)
In-Reply-To: <000d01ceaf81$a9910aa0$fcb31fe0$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/tty/serial/8250/8250_pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index c810da7..515fd0f 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -3520,8 +3520,6 @@ static void pciserial_remove_one(struct pci_dev *dev)
{
struct serial_private *priv = pci_get_drvdata(dev);
- pci_set_drvdata(dev, NULL);
-
pciserial_remove_ports(priv);
pci_disable_device(dev);
--
1.7.10.4
next prev parent reply other threads:[~2013-09-12 6:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 6:31 [PATCH 1/3] serial: mfd: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-12 6:33 ` Jingoo Han [this message]
2013-09-12 14:47 ` [PATCH 2/3] serial: 8250_pci: " Wang YanQing
2013-09-12 6:35 ` [PATCH 3/3] serial: txx9: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000e01ceaf82$0a2fff10$1e8ffd30$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=schivers@csc.com \
--cc=shurd@broadcom.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).