* [PATCH 1/2] serial: st-asc: remove unnecessary platform_set_drvdata()
@ 2013-08-22 2:06 Jingoo Han
2013-08-22 2:08 ` [PATCH 2/2] TTY: amiserial, " Jingoo Han
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-22 2:06 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: linux-serial, 'Srinivas Kandagatla', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/tty/serial/st-asc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index 4f5caa38..21e6e84 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -753,7 +753,6 @@ static int asc_serial_remove(struct platform_device *pdev)
{
struct uart_port *port = platform_get_drvdata(pdev);
- platform_set_drvdata(pdev, NULL);
return uart_remove_one_port(&asc_uart_driver, port);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] TTY: amiserial, remove unnecessary platform_set_drvdata()
2013-08-22 2:06 [PATCH 1/2] serial: st-asc: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-08-22 2:08 ` Jingoo Han
0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2013-08-22 2:08 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'; +Cc: linux-serial, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/tty/amiserial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 083710e..2b86f8e 100644
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -1785,8 +1785,6 @@ static int __exit amiga_serial_remove(struct platform_device *pdev)
free_irq(IRQ_AMIGA_TBE, state);
free_irq(IRQ_AMIGA_RBF, state);
- platform_set_drvdata(pdev, NULL);
-
return error;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-22 2:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 2:06 [PATCH 1/2] serial: st-asc: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 2:08 ` [PATCH 2/2] TTY: amiserial, " Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).