RE: Adding new driver - looking for suggestions

Chris Doré
2007-07-11T14:20:33Z

On July 10, 2007 5:35 PM, Frantisek Rysanek wrote:
>
> As far as patching the vanilla kernel is concerned:
> You seem to suggest an addition of rather proprietary data (members)
> to the neatly generic struct uart_port. I'd suggest adding something
> like
>
> void* priv; // device-specific driver private data

I agree, I'm not a fan of the current implementation. I'd like to massage
what we have into something more acceptable.

> to the generic struct uart_port of the vanilla kernel, which you
> could then use to hook your own private data struct, regardless of
> whether the rest of your driver lives in 8250_pci.c or in a stand-
> alone module. This is the way it's done in a number of other generic
> device structs (or maybe the more modern way is to use a nested
> struct with "parent struct decoding").

Thanks for the ideas.

Chris Doré

-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html