From: Jingoo Han <jg1.han@samsung.com>
To: 'Fabio Estevam' <festevam@gmail.com>,
'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org,
'Fabio Estevam' <fabio.estevam@freescale.com>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] serial: samsung: Use %pa to print 'resource_size_t' type
Date: Thu, 05 Jun 2014 10:12:56 +0900 [thread overview]
Message-ID: <006f01cf805b$48589d60$d909d820$%han@samsung.com> (raw)
In-Reply-To: <1401923201-5477-1-git-send-email-festevam@gmail.com>
On Thursday, June 05, 2014 8:07 AM, Fabio Estevam wrote:
>
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning
> is seen:
>
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port':
> drivers/tty/serial/samsung.c:1229:2: warning: format '%x' expects argument of type 'unsigned int', but
> argument 2 has type 'resource_size_t' [-Wformat]
>
> Use %pa to print 'resource_size_t' type to fix the warning.
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/tty/serial/samsung.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3293377..b7b8185 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1226,8 +1226,8 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
> wr_regl(port, S3C64XX_UINTSP, 0xf);
> }
>
> - dbg("port: map=%08x, mem=%p, irq=%d (%d,%d), clock=%u\n",
> - port->mapbase, port->membase, port->irq,
> + dbg("port: map=%pa, mem=%p, irq=%d (%d,%d), clock=%u\n",
> + &port->mapbase, port->membase, port->irq,
> ourport->rx_irq, ourport->tx_irq, port->uartclk);
>
> /* reset the fifos (and setup the uart) */
> --
> 1.8.3.2
prev parent reply other threads:[~2014-06-05 1:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 23:06 [PATCH] serial: samsung: Use %pa to print 'resource_size_t' type Fabio Estevam
2014-06-05 1:12 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006f01cf805b$48589d60$d909d820$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox