From: "Stuart MacDonald" <stuartm@connecttech.com>
To: rwhite@pobox.com, Ed Vance <EdV@macrolink.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
'Russell King' <rmk@arm.linux.org.uk>,
'Theodore Tso' <tytso@mit.edu>
Subject: Re: n_tty.c driver patch (semantic and performance correction) (a ll recent versions)
Date: Tue, 18 Jun 2002 09:05:20 -0400 [thread overview]
Message-ID: <008001c216c8$d0bfdba0$294b82ce@connecttech.com> (raw)
In-Reply-To: 200206171900.03955.rwhite@pobox.com
From: "Robert White" <rwhite@pobox.com>
> should you use your greater-access to the code and user base, you would
find
> a single case where it breaks, invalidates, or confuses a single person or
> program on the planet.
I can see one easy case: protocol has frame size of N. VMIN is set to
say 3 * N. read() supplies a buffer of N. The purpose being that the
first read will block until 3 frames are ready to process, then return
the first one. Your patch would break that.
Having said that, I don't know of any instances where the above is
employed. I'd say your patch is worthwhile.
..Stu
next prev parent reply other threads:[~2002-06-18 13:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-17 17:27 n_tty.c driver patch (semantic and performance correction) (a ll recent versions) Ed Vance
2002-06-18 2:00 ` Robert White
[not found] ` <200206171900.03955.rwhite@pobox.com>
2002-06-18 13:05 ` Stuart MacDonald [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-06-26 17:48 Ed Vance
2002-06-26 20:42 ` Russell King
2002-06-27 16:37 ` Robert White
2002-07-26 14:17 ` Russell King
2002-07-27 22:07 ` Robert White
2002-07-27 23:11 ` Russell King
2002-07-27 23:21 ` Andries Brouwer
2002-07-28 2:34 ` Robert White
2002-07-28 3:01 ` Stevie O
2002-07-28 13:34 ` Andries Brouwer
2002-07-28 20:04 ` Alan Cox
[not found] ` <1027886676.790.5.camel@irongate.swansea.linux.org.uk>
2002-07-30 7:41 ` Robert White
2002-07-28 2:36 ` Robert White
2002-06-28 18:12 Ed Vance
2002-07-29 21:46 Ed Vance
2002-07-30 7:50 ` Robert White
2002-07-30 17:07 Ed Vance
[not found] <11E89240C407D311958800A0C9ACF7D13A7915@EXCHANGE>
2002-07-31 5:31 ` David Lawyer
2002-07-31 16:58 Ed Vance
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008001c216c8$d0bfdba0$294b82ce@connecttech.com' \
--to=stuartm@connecttech.com \
--cc=EdV@macrolink.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=rwhite@pobox.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox