From: Viresh Kumar <viresh.kumar@linaro.org>
To: gregkh@linuxfoundation.org, jslaby@suse.cz
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
linux-serial@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V2 10/25] tty: serial: lpc32xx_hs: don't call tty_flip_buffer_push() twice
Date: Mon, 19 Aug 2013 20:14:14 +0530 [thread overview]
Message-ID: <00d9c7ce1f24cdaae6707fc71c957cc65b854751.1376923198.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1376923198.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1376923198.git.viresh.kumar@linaro.org>
serial_lpc32xx_interrupt() calls __serial_lpc32xx_rx() first and then
tty_flip_buffer_push() immediately after that. But last statement of
__serial_lpc32xx_rx() already called tty_flip_buffer_push()..
So, probably its not required to be called twice. Lets remove one of them.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/tty/serial/lpc32xx_hs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c
index dffea6b..8fdf6a8 100644
--- a/drivers/tty/serial/lpc32xx_hs.c
+++ b/drivers/tty/serial/lpc32xx_hs.c
@@ -351,10 +351,8 @@ static irqreturn_t serial_lpc32xx_interrupt(int irq, void *dev_id)
}
/* Data received? */
- if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT)) {
+ if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT))
__serial_lpc32xx_rx(port);
- tty_flip_buffer_push(tport);
- }
/* Transmit data request? */
if ((status & LPC32XX_HSU_TX_INT) && (!uart_tx_stopped(port))) {
--
1.7.12.rc2.18.g61b472e
next prev parent reply other threads:[~2013-08-19 14:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 14:44 [PATCH V2 00/25] tty: serial: drop uart_port->lock before calling Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 01/25] tty: serial: altera_jtag: drop uart_port->lock before calling tty_flip_buffer_push() Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 02/25] tty: serial: altera: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 03/25] tty: serial: apbuart: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 04/25] tty: serial: ar933x: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 05/25] tty: serial: arc: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 06/25] tty: serial: bcm63xx: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 07/25] tty: serial: bfin_sport: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 08/25] tty: serial: efm32: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 09/25] tty: serial: icom: " Viresh Kumar
2013-08-19 14:44 ` Viresh Kumar [this message]
2013-08-19 14:44 ` [PATCH V2 11/25] tty: serial: lpc32xx_hs: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 12/25] tty: serial: m32r_sio: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 13/25] tty: serial: mcf: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 14/25] tty: serial: mfd: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 15/25] tty: serial: mpsc: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 16/25] tty: serial: msm: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 17/25] tty: serial: netx: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 18/25] tty: serial: nwpserial: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 19/25] tty: serial: pnx8xxx: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 20/25] tty: serial: rp2: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 21/25] tty: serial: sa1100: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 22/25] tty: serial: samsung: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 23/25] tty: serial: tegra: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 24/25] tty: serial: sirfsoc: " Viresh Kumar
2013-08-19 14:44 ` [PATCH V2 25/25] tty: serial: vt8500: " Viresh Kumar
2013-08-19 15:31 ` [PATCH V2 00/25] tty: serial: drop uart_port->lock before calling Peter Hurley
2013-08-20 0:18 ` Viresh Kumar
2013-08-20 2:35 ` Peter Hurley
2013-08-20 10:52 ` Viresh Kumar
2013-08-20 19:38 ` Peter Hurley
2013-08-21 4:35 ` Viresh Kumar
2013-08-23 8:26 ` Viresh Kumar
2013-08-27 23:19 ` Greg Kroah-Hartman
2013-08-28 3:31 ` Viresh Kumar
2013-08-28 3:43 ` Greg Kroah-Hartman
2013-08-28 3:45 ` Viresh Kumar
2013-08-28 5:58 ` Viresh Kumar
2013-08-28 6:05 ` Greg Kroah-Hartman
2013-08-28 6:07 ` Viresh Kumar
2013-08-28 6:15 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00d9c7ce1f24cdaae6707fc71c957cc65b854751.1376923198.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-serial@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).