public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: "Chris Doré" <cdore@connecttech.com>
To: linux-serial <linux-serial@vger.kernel.org>
Subject: tty_struct size
Date: Mon, 22 Sep 2008 08:23:32 -0400	[thread overview]
Message-ID: <011c01c91cae$08df7800$1a9e6800$@com> (raw)

Hi all,

Sorry if this has been covered before, I just want to clarify a comment
about the size of the tty_struct structure that I see in older kernels
(2.4.22 era).

tty.h:
"IMPORTANT: since this structure is dynamically allocated, it must be no
larger than 4096 bytes.  Changing TTY_FLIPBUF_SIZE will change the size of
this structure, and it needs to be done with care."

Doing some research I believe this comment is from a time when the TTY
structures were allocated using get_zeroed_page(), hence the page size
looking limit in the comment.  Since kmalloc() is now used it would seem
that this comment no longer applies, however I wanted to make sure that the
4K limit is not there for another reason.

So, do I need to worry about the size of tty_struct (I'm going to experiment
with the flip buffer, on 2.4.22)?


Thanks, Chris



                 reply	other threads:[~2008-09-22 12:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011c01c91cae$08df7800$1a9e6800$@com' \
    --to=cdore@connecttech.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox