linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* tty_struct size
@ 2008-09-22 12:23 Chris Doré
  0 siblings, 0 replies; only message in thread
From: Chris Doré @ 2008-09-22 12:23 UTC (permalink / raw)
  To: linux-serial

Hi all,

Sorry if this has been covered before, I just want to clarify a comment
about the size of the tty_struct structure that I see in older kernels
(2.4.22 era).

tty.h:
"IMPORTANT: since this structure is dynamically allocated, it must be no
larger than 4096 bytes.  Changing TTY_FLIPBUF_SIZE will change the size of
this structure, and it needs to be done with care."

Doing some research I believe this comment is from a time when the TTY
structures were allocated using get_zeroed_page(), hence the page size
looking limit in the comment.  Since kmalloc() is now used it would seem
that this comment no longer applies, however I wanted to make sure that the
4K limit is not there for another reason.

So, do I need to worry about the size of tty_struct (I'm going to experiment
with the flip buffer, on 2.4.22)?


Thanks, Chris



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-09-22 12:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-22 12:23 tty_struct size Chris Doré

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).