From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
Cc: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Jiri Slaby'" <jirislaby@kernel.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'Hector Martin'" <marcan@marcan.st>,
"'Jaewon Kim'" <jaewon02.kim@samsung.com>,
"'Vincent Whitchurch'" <vincent.whitchurch@axis.com>,
"'Ilpo Järvinen'" <ilpo.jarvinen@linux.intel.com>,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v2] tty: serial: samsung_tty: loopback mode support
Date: Wed, 29 Jun 2022 09:32:45 +0900 [thread overview]
Message-ID: <012501d88b4f$c08a5c80$419f1580$@samsung.com> (raw)
In-Reply-To: <YrsHaUqM03I6I9Om@kroah.com>
> > We can test it by linux-serial-test program with -k option. The tool
> > will set TIOCM_LOOP mode when the option is specified.
> > -k, --loopback Use internal hardware loop back
>
> Again, what does this line mean in a changelog text?
I put the option to refer how the tool can use. I can see it is not related
with this commit.
I'll remove them next patch.
>
> And properly wrap your lines at 72 columns.
I'll keep that in mind.
Thanks for your review :)
Best Regards,
Chanho Park
prev parent reply other threads:[~2022-06-29 0:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220628124300epcas2p45f1e3a7051bb93ecba778cf7d96720d3@epcas2p4.samsung.com>
2022-06-28 12:40 ` [PATCH v2] tty: serial: samsung_tty: loopback mode support Chanho Park
2022-06-28 12:58 ` Ilpo Järvinen
2022-06-29 0:29 ` Chanho Park
2022-06-28 13:51 ` Greg Kroah-Hartman
2022-06-29 0:32 ` Chanho Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='012501d88b4f$c08a5c80$419f1580$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jaewon02.kim@samsung.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox