From: Krzysztof Kozlowski <krzk@kernel.org>
To: shao.mingyin@zte.com.cn, alim.akhtar@samsung.com
Cc: yang.yang29@zte.com.cn, xu.xin16@zte.com.cn,
ye.xingchen@zte.com.cn, gregkh@linuxfoundation.org,
jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, jiang.peng9@zte.com.cn
Subject: Re: [PATCH] tty: serial: samsung: Fix potential buffer overflow in clkname
Date: Tue, 1 Apr 2025 14:52:06 +0200 [thread overview]
Message-ID: <017349ed-d1fd-418e-90ca-a7113cafd025@kernel.org> (raw)
In-Reply-To: <20250401192420169tLRsDis5R0RrVmdFnFuS9@zte.com.cn>
On 01/04/2025 13:24, shao.mingyin@zte.com.cn wrote:
> From: Peng Jiang <jiang.peng9@zte.com.cn>
>
> Compiling the kernel with gcc12.3 W=1 produces a warning:
> /drivers/tty/serial/samsung_tty.c: In function
> 's3c24xx_serial_set_termios':
>
> /drivers/tty/serial/samsung_tty.c:1392:48:
> warning: '%d' directive writing between 1 and 3 bytes
> into a region of size 2 [-Wformat-overflow=]
> 1392 | sprintf(clkname, "clk_uart_baud%d", cnt);
Same comments as with other patches, not possible, IMO. Plus this patch
looks actually worse - commit msg is hardly readable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-01 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 11:24 [PATCH] tty: serial: samsung: Fix potential buffer overflow in clkname shao.mingyin
2025-04-01 12:52 ` Krzysztof Kozlowski [this message]
2025-04-02 1:33 ` jiang.peng9
2025-04-02 4:44 ` Jiri Slaby
2025-04-02 6:28 ` jiang.peng9
2025-04-02 6:27 ` Krzysztof Kozlowski
2025-04-02 6:49 ` jiang.peng9
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=017349ed-d1fd-418e-90ca-a7113cafd025@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.peng9@zte.com.cn \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shao.mingyin@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox