From: Michael Moese <mmoese@suse.de>
To: Colin King <colin.king@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 8250-men-mcb: fix error checking when get_num_ports returns -ENODEV
Date: Mon, 14 Oct 2019 08:55:15 +0200 [thread overview]
Message-ID: <022c9a2b-0929-3a76-7976-dca717a5bc73@suse.de> (raw)
In-Reply-To: <20191013220016.9369-1-colin.king@canonical.com>
On 14.10.19 00:00, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The current checking for failure on the number of ports fails when
> -ENODEV is returned from the call to get_num_ports. Fix this by making
> num_ports and loop counter i signed rather than unsigned ints. Also
> add check for num_ports being less than zero to check for -ve error
> returns.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: e2fea54e4592 ("8250-men-mcb: add support for 16z025 and 16z057")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This looks more than reasonable to me, thanks.
Reviewed-by: Michael Moese <mmoese@suse.de>
> ---
> drivers/tty/serial/8250/8250_men_mcb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_men_mcb.c b/drivers/tty/serial/8250/8250_men_mcb.c
> index 02c5aff58a74..8df89e9cd254 100644
> --- a/drivers/tty/serial/8250/8250_men_mcb.c
> +++ b/drivers/tty/serial/8250/8250_men_mcb.c
> @@ -72,8 +72,8 @@ static int serial_8250_men_mcb_probe(struct mcb_device *mdev,
> {
> struct serial_8250_men_mcb_data *data;
> struct resource *mem;
> - unsigned int num_ports;
> - unsigned int i;
> + int num_ports;
> + int i;
> void __iomem *membase;
>
> mem = mcb_get_resource(mdev, IORESOURCE_MEM);
> @@ -88,7 +88,7 @@ static int serial_8250_men_mcb_probe(struct mcb_device *mdev,
> dev_dbg(&mdev->dev, "found a 16z%03u with %u ports\n",
> mdev->id, num_ports);
>
> - if (num_ports == 0 || num_ports > 4) {
> + if (num_ports <= 0 || num_ports > 4) {
> dev_err(&mdev->dev, "unexpected number of ports: %u\n",
> num_ports);
> return -ENODEV;
> @@ -133,7 +133,7 @@ static int serial_8250_men_mcb_probe(struct mcb_device *mdev,
>
> static void serial_8250_men_mcb_remove(struct mcb_device *mdev)
> {
> - unsigned int num_ports, i;
> + int num_ports, i;
> struct serial_8250_men_mcb_data *data = mcb_get_drvdata(mdev);
>
> if (!data)
>
--
Michael Moese <mmoese@suse.de>
QA Engineer
PGP Fingerprint: 4CCE 3896 F873 2CA5 2382 3C6F 6021 375C 8635 7E74
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 247165, AG München)
Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2019-10-14 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 22:00 [PATCH] 8250-men-mcb: fix error checking when get_num_ports returns -ENODEV Colin King
2019-10-13 22:00 ` Colin King
2019-10-14 6:55 ` Michael Moese [this message]
2019-10-14 6:55 ` Michael Moese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=022c9a2b-0929-3a76-7976-dca717a5bc73@suse.de \
--to=mmoese@suse.de \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox