From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Thomas Abraham' <thomas.abraham@linaro.org>,
linux-serial@vger.kernel.org
Cc: gregkh@linuxfoundation.org, alan@linux.intel.com,
linux-samsung-soc@vger.kernel.org
Subject: RE: [PATCH] serial: samsung: remove redundant setting of line config during port reset
Date: Mon, 31 Dec 2012 14:03:46 -0800 [thread overview]
Message-ID: <032f01cde7a2$b6a7a250$23f6e6f0$@samsung.com> (raw)
In-Reply-To: <1356990165-3905-1-git-send-email-thomas.ab@samsung.com>
Thomas Abraham wrote:
>
> The setting of uart line control configuration in s3c24xx_serial_resetport
> is can be removed since the 'set_termios' call will overwrite any ULCON
> register setting which s3c24xx_serial_resetport does.
>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Greg, if you're ok on this, please pick this up for v3.8
Happy New Year!!!
- Kukjin
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
> drivers/tty/serial/samsung.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 12e5249..e514b3a 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1006,7 +1006,6 @@ static void s3c24xx_serial_resetport(struct
> uart_port *port,
>
> ucon &= ucon_mask;
> wr_regl(port, S3C2410_UCON, ucon | cfg->ucon);
> - wr_regl(port, S3C2410_ULCON, cfg->ulcon);
>
> /* reset both fifos */
> wr_regl(port, S3C2410_UFCON, cfg->ufcon |
> S3C2410_UFCON_RESETBOTH);
> --
> 1.7.5.4
prev parent reply other threads:[~2012-12-31 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 21:42 [PATCH] serial: samsung: remove redundant setting of line config during port reset Thomas Abraham
2012-12-31 22:03 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='032f01cde7a2$b6a7a250$23f6e6f0$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).