* [PATCH] serial: samsung: remove redundant setting of line config during port reset
@ 2012-12-31 21:42 Thomas Abraham
2012-12-31 22:03 ` Kukjin Kim
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Abraham @ 2012-12-31 21:42 UTC (permalink / raw)
To: linux-serial; +Cc: gregkh, alan, kgene.kim, linux-samsung-soc
The setting of uart line control configuration in s3c24xx_serial_resetport
is can be removed since the 'set_termios' call will overwrite any ULCON
register setting which s3c24xx_serial_resetport does.
Cc: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
---
drivers/tty/serial/samsung.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 12e5249..e514b3a 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1006,7 +1006,6 @@ static void s3c24xx_serial_resetport(struct uart_port *port,
ucon &= ucon_mask;
wr_regl(port, S3C2410_UCON, ucon | cfg->ucon);
- wr_regl(port, S3C2410_ULCON, cfg->ulcon);
/* reset both fifos */
wr_regl(port, S3C2410_UFCON, cfg->ufcon | S3C2410_UFCON_RESETBOTH);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] serial: samsung: remove redundant setting of line config during port reset
2012-12-31 21:42 [PATCH] serial: samsung: remove redundant setting of line config during port reset Thomas Abraham
@ 2012-12-31 22:03 ` Kukjin Kim
0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2012-12-31 22:03 UTC (permalink / raw)
To: 'Thomas Abraham', linux-serial; +Cc: gregkh, alan, linux-samsung-soc
Thomas Abraham wrote:
>
> The setting of uart line control configuration in s3c24xx_serial_resetport
> is can be removed since the 'set_termios' call will overwrite any ULCON
> register setting which s3c24xx_serial_resetport does.
>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Greg, if you're ok on this, please pick this up for v3.8
Happy New Year!!!
- Kukjin
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
> drivers/tty/serial/samsung.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 12e5249..e514b3a 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1006,7 +1006,6 @@ static void s3c24xx_serial_resetport(struct
> uart_port *port,
>
> ucon &= ucon_mask;
> wr_regl(port, S3C2410_UCON, ucon | cfg->ucon);
> - wr_regl(port, S3C2410_ULCON, cfg->ulcon);
>
> /* reset both fifos */
> wr_regl(port, S3C2410_UFCON, cfg->ufcon |
> S3C2410_UFCON_RESETBOTH);
> --
> 1.7.5.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-31 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-31 21:42 [PATCH] serial: samsung: remove redundant setting of line config during port reset Thomas Abraham
2012-12-31 22:03 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).