From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Thomas Abraham' <thomas.abraham@linaro.org>,
'Mark Brown' <broonie@opensource.wolfsonmicro.com>
Cc: 'Alan Cox' <alan@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] serial: samsung: Fix build for non-Exynos4210 devices
Date: Tue, 08 Nov 2011 14:00:31 +0900 [thread overview]
Message-ID: <04ea01cc9dd3$5725b110$05711330$%kim@samsung.com> (raw)
In-Reply-To: <CAJuYYwQakbLqM46gVexB4Evby-aHA11hAx4N4Nw4mdYXp_yEOQ@mail.gmail.com>
Thomas Abraham wrote:
>
> Hi Mark,
>
> On 4 November 2011 22:46, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
> > exynos4120_serial_drv_data is only defined when building with support
> > for Exynos4210 so use the already provided define to ensure that we
> > don't reference it when building for other SoCs.
> >
> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> I missed that one. Thanks for the fix.
>
> The Samsung device tree patches will not be merged in v3.2 merge
> window. So should this fix be merged into the uart dt support patch or
> should this be a separate patch?
>
Hi all,
Okay, I will pick this up on 'next-samung-dt' tree which will be sent to
upstream in next time.
As a note, I need to sort out the tree based on v3.2-rc1 then will apply
this.
If any problems, please let me know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> > ---
> > drivers/tty/serial/samsung.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> > index efe3756..7272eee 100644
> > --- a/drivers/tty/serial/samsung.c
> > +++ b/drivers/tty/serial/samsung.c
> > @@ -1649,7 +1649,7 @@ MODULE_DEVICE_TABLE(platform,
> s3c24xx_serial_driver_ids);
> > #ifdef CONFIG_OF
> > static const struct of_device_id s3c24xx_uart_dt_match[] = {
> > { .compatible = "samsung,exynos4210-uart",
> > - .data = &exynos4210_serial_drv_data },
> > + .data = EXYNOS4210_SERIAL_DRV_DATA },
> > {},
> > };
> > MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match);
> > --
> > 1.7.7.1
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-11-08 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 17:16 [PATCH] serial: samsung: Fix build for non-Exynos4210 devices Mark Brown
2011-11-06 16:13 ` Thomas Abraham
2011-11-08 5:00 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='04ea01cc9dd3$5725b110$05711330$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=alan@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox