* [PATCH] serial: samsung: Remove redundant DEBUG_LL check
@ 2015-07-13 11:18 Javier Martinez Canillas
2015-07-14 1:56 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2015-07-13 11:18 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-samsung-soc, Jiri Slaby, Krzysztof Kozlowski, Arnd Bergmann,
linux-kernel, Kukjin Kim, linux-serial, linux-arm-kernel,
Javier Martinez Canillas
Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
build issues when the driver was built as a module. One of those was
that printascii is only accessible when the driver is built-in.
But there is no need to check for defined(CONFIG_DEBUG_LL) since the
SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/tty/serial/samsung.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 67d0c213b1c7..8c963d6d9074 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -53,7 +53,6 @@
#include "samsung.h"
#if defined(CONFIG_SERIAL_SAMSUNG_DEBUG) && \
- defined(CONFIG_DEBUG_LL) && \
!defined(MODULE)
extern void printascii(const char *);
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] serial: samsung: Remove redundant DEBUG_LL check
2015-07-13 11:18 [PATCH] serial: samsung: Remove redundant DEBUG_LL check Javier Martinez Canillas
@ 2015-07-14 1:56 ` Krzysztof Kozlowski
2015-07-14 4:41 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-14 1:56 UTC (permalink / raw)
To: Javier Martinez Canillas, Greg Kroah-Hartman
Cc: linux-samsung-soc, Jiri Slaby, Arnd Bergmann, linux-kernel,
Kukjin Kim, linux-serial, linux-arm-kernel
On 13.07.2015 20:18, Javier Martinez Canillas wrote:
> Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
> build issues when the driver was built as a module. One of those was
> that printascii is only accessible when the driver is built-in.
>
> But there is no need to check for defined(CONFIG_DEBUG_LL) since the
> SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/tty/serial/samsung.c | 1 -
> 1 file changed, 1 deletion(-)
Although this redundancy is not harmful the patch seems fine, so:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] serial: samsung: Remove redundant DEBUG_LL check
2015-07-14 1:56 ` Krzysztof Kozlowski
@ 2015-07-14 4:41 ` Kukjin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2015-07-14 4:41 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Javier Martinez Canillas',
'Greg Kroah-Hartman'
Cc: linux-samsung-soc, 'Arnd Bergmann', linux-kernel,
'Kukjin Kim', linux-serial, 'Jiri Slaby',
linux-arm-kernel
Krzysztof Kozlowski wrote:
>
> On 13.07.2015 20:18, Javier Martinez Canillas wrote:
> > Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
> > build issues when the driver was built as a module. One of those was
> > that printascii is only accessible when the driver is built-in.
> >
> > But there is no need to check for defined(CONFIG_DEBUG_LL) since the
> > SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
> >
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Kukjin Kim <kgene@kernel.org>
Thanks,
Kukjin
> >
> > ---
> >
> > drivers/tty/serial/samsung.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Although this redundancy is not harmful the patch seems fine, so:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-14 4:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 11:18 [PATCH] serial: samsung: Remove redundant DEBUG_LL check Javier Martinez Canillas
2015-07-14 1:56 ` Krzysztof Kozlowski
2015-07-14 4:41 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).