From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
To: Colin King <colin.king@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: jsm: remove redundant pointer ts
Date: Tue, 7 Nov 2017 10:53:47 -0200 [thread overview]
Message-ID: <077747a9-4ed2-9716-4de6-35f2fa269183@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171107114107.22805-1-colin.king@canonical.com>
On 11/07/2017 09:41 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer ts is assigned a value that is never read, ts is therefore
> redundant and can be removed. Cleans up clang warning:
>
> drivers/tty/serial/jsm/jsm_tty.c:285:2: warning: Value stored to 'ts'
> is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin!
Acked-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
> ---
> drivers/tty/serial/jsm/jsm_tty.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
> index e69227cc3827..5ecd878669b8 100644
> --- a/drivers/tty/serial/jsm/jsm_tty.c
> +++ b/drivers/tty/serial/jsm/jsm_tty.c
> @@ -275,14 +275,12 @@ static int jsm_tty_open(struct uart_port *port)
> static void jsm_tty_close(struct uart_port *port)
> {
> struct jsm_board *bd;
> - struct ktermios *ts;
> struct jsm_channel *channel =
> container_of(port, struct jsm_channel, uart_port);
>
> jsm_dbg(CLOSE, &channel->ch_bd->pci_dev, "start\n");
>
> bd = channel->ch_bd;
> - ts = &port->state->port.tty->termios;
>
> channel->ch_flags &= ~(CH_STOPI);
>
prev parent reply other threads:[~2017-11-07 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 11:41 [PATCH] tty: serial: jsm: remove redundant pointer ts Colin King
2017-11-07 12:53 ` Guilherme G. Piccoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=077747a9-4ed2-9716-4de6-35f2fa269183@linux.vnet.ibm.com \
--to=gpiccoli@linux.vnet.ibm.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox