From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0752E92721 for ; Thu, 5 Oct 2023 16:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229540AbjJEQnT (ORCPT ); Thu, 5 Oct 2023 12:43:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232464AbjJEQlj (ORCPT ); Thu, 5 Oct 2023 12:41:39 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7DEF49C4 for ; Wed, 4 Oct 2023 22:05:46 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-533df112914so841857a12.0 for ; Wed, 04 Oct 2023 22:05:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1696482345; x=1697087145; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tumpG4fZu91mYpt2qQbWwuFfddli9/TW76sKXIYzTOk=; b=deQ7A4mY5ePOw4jHVnPJCqadPHGXWot17MfTlsuzPmL1tAKWWcgtfIzYCl6Y26RH/2 Tg5vtPBAu0gJKO7CFEu7p2di+9Zo7ZnGiByuPZRH4rVpEmvI6Ad5Z1u3CH752De5xk+b 6k6CTfr0mgVEyVtkEVStiiy6ER34FpSe0ONd2J1hDIrOt+KFaJzkK7e2ZCnkgu2oFmTx hJYJmKEe1oqQ26KbG9i+ATT9szB+0wzhWfDLnsox8IPOw7cn1kAP95Htmm4YSPIftgTn WIV57dECWvJJjG2shxvBLoZgUjtRC3J09TgpgpGGMiZclNTXmV2XoELeTgvgyRXZqaUB pGSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696482345; x=1697087145; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tumpG4fZu91mYpt2qQbWwuFfddli9/TW76sKXIYzTOk=; b=Se/dxak1Frmrq17Pw6Wt0lccZ4akpPRlVU3eaFDAbElEN3KVa51Pg847KwKaAZrwnN nh6Ts50qEKsQB2HsypTeLrCieR5kvmQw88PDX2aAlAlxMbGlQ37jOwb7x+Ki0avtLVRF z8crqn9XI4GYlc8FIt1Fx9vBV4LqobSj+xEVWM6OBKEDd+/otTRhWwKwG/um9NgS0QCe ZxmvSozNybSxnUb7lVMD1Fl0b3OIYxvYgYuvg9lYAuKdZMRwjfkrQmDDtAUebYGRNZRt ItCXQk1l1EgpMDnRmAyyi6oJJy5XQLmPEhHXNVlGjMP9m3hUG/LE2LHF952k60OI/WKl 0Dtw== X-Gm-Message-State: AOJu0YyfpnrKE0YzffbW5lEMOgrXQczi8Bcw5CiT8Hyp1bK8tgdmX45P 07oRRoTKdBJ4vP9qQmBJb11ITg== X-Google-Smtp-Source: AGHT+IE54MO+fhgdky4xkVipD6Wj3FDv6iN+CshxB2o1CFdPuoVHF2KKTNg0ZjphMiuqlQstCFMd7w== X-Received: by 2002:aa7:da8c:0:b0:530:9b94:96e with SMTP id q12-20020aa7da8c000000b005309b94096emr3525467eds.41.1696482345190; Wed, 04 Oct 2023 22:05:45 -0700 (PDT) Received: from [192.168.32.2] ([147.161.130.252]) by smtp.gmail.com with ESMTPSA id u15-20020aa7d98f000000b00533bab9d9f1sm434409eds.1.2023.10.04.22.05.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Oct 2023 22:05:44 -0700 (PDT) Message-ID: <08ed16ff-14ca-a7e2-59c2-da949ceaa608@tuxon.dev> Date: Thu, 5 Oct 2023 08:05:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 18/28] pinctrl: renesas: rzg2l: add support for different ds values on different groups Content-Language: en-US To: Geert Uytterhoeven Cc: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linus.walleij@linaro.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, magnus.damm@gmail.com, catalin.marinas@arm.com, will@kernel.org, quic_bjorande@quicinc.com, konrad.dybcio@linaro.org, arnd@arndb.de, neil.armstrong@linaro.org, prabhakar.mahadev-lad.rj@bp.renesas.com, biju.das.jz@bp.renesas.com, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230929053915.1530607-1-claudiu.beznea@bp.renesas.com> <20230929053915.1530607-19-claudiu.beznea@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 04.10.2023 16:17, Geert Uytterhoeven wrote: > On Fri, Sep 29, 2023 at 7:39 AM Claudiu wrote: >> From: Claudiu Beznea >> >> RZ/G3S supports different drive strength values for different power sources >> and pin groups (A, B, C). On each group there could be up to 4 drive >> strength values per power source. Available power sources are 1v8, 2v5, >> 3v3. Drive strength values are fine tuned than what was previously >> available on the driver thus the necessity of having micro-amp support. >> As drive strength and power source values are linked together the >> hardware setup for these was moved at the end of >> rzg2l_pinctrl_pinconf_set() to ensure proper validation of the new >> values. >> >> The drive strength values are expected to be initialized though SoC >> specific hardware configuration data structure. >> >> Signed-off-by: Claudiu Beznea >> --- >> >> Changes in v2: >> - s/strenght/strength, s/togheter/together in commit description >> - got rid of RZG2L_INVALID_IOLH_VAL macro and consider zero as invalid >> value for entries in struct rzg2l_hwcfg::iolh_group[abc]_ua[] arrays >> - removed spinlock in rzg2l_[sg]et_power_source() >> - introduced caps_to_pwr_reg() and simplified the code in >> rzg2l_[sg]et_power_source() >> - changed return type of rzg2l_iolh_ua_to_val() to int and return >> -EINVAL on failure cases >> - s/rzg2l_ds_supported/rzg2l_ds_is_supported >> - inverted the logic in rzg2l_pinctrl_pinconf_set() when applying drive >> strength and power source to hardware registers and thus simplified the >> code >> - used devm_kcalloc() instead of devm_kzalloc() >> - adderessed the rest of the review comments > > Thanks, will queue in renesas-pinctrl-for-v6.7, with Paul's comment > addresses. Thank you Geert and Paul! > > Gr{oetje,eeting}s, > > Geert >