From: Jiri Slaby <jirislaby@kernel.org>
To: Mingyu Wang <25181214217@stu.xidian.edu.cn>, gregkh@linuxfoundation.org
Cc: ilpo.jarvinen@linux.intel.com, john.ogness@linutronix.de,
andriy.shevchenko@linux.intel.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller@googlegroups.com,
stable@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: validate iomem_base in serial8250_verify_port()
Date: Mon, 20 Jul 2026 08:08:48 +0200 [thread overview]
Message-ID: <0d58c9fe-7aed-43dd-8d00-6edfee9e2876@kernel.org> (raw)
In-Reply-To: <20260720053733.102186-1-25181214217@stu.xidian.edu.cn>
On 20. 07. 26, 7:37, Mingyu Wang wrote:
> Fix this by tightening the validation in serial8250_verify_port().
> Reject any TIOCSSERIAL requests that attempt to modify the io_type
> to/from memory-mapped types, or change the iomem_base of an existing
> memory-mapped port. Userspace can still legitimately modify IRQs or
> baud rates of MMIO ports as long as the io_type and mapbase remain
> unchanged.
Pardon my ignorance, but isn't TIOCSSERIAL intended exactly to change
the type or mapbase when needed for ports without UPF_FIXED_PORT (and
under root)?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2026-07-20 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 5:37 [PATCH] serial: 8250: validate iomem_base in serial8250_verify_port() Mingyu Wang
2026-07-20 6:08 ` Jiri Slaby [this message]
2026-07-20 6:44 ` Mingyu Wang
2026-07-20 6:47 ` Greg KH
2026-07-20 7:36 ` Mingyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d58c9fe-7aed-43dd-8d00-6edfee9e2876@kernel.org \
--to=jirislaby@kernel.org \
--cc=25181214217@stu.xidian.edu.cn \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox