From: Jiri Slaby <jirislaby@kernel.org>
To: Tom Rix <trix@redhat.com>,
hammerh0314@gmail.com, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: sunplus-uart: change sunplus_console_ports from global to static
Date: Fri, 22 Apr 2022 07:18:22 +0200 [thread overview]
Message-ID: <0da4659a-6efb-9734-49cb-968558033a56@kernel.org> (raw)
In-Reply-To: <20220421152505.1531507-1-trix@redhat.com>
On 21. 04. 22, 17:25, Tom Rix wrote:
> Smatch reports this issue
> sunplus-uart.c:501:26: warning: symbol 'sunplus_console_ports' was not declared. Should it be static?
>
> sunplus_console_ports is only used in sunplus-uart.c so change
> its storage-class specifier to static
Heh, coincidentally, I've sent the same fix yesterday too:
https://lore.kernel.org/all/20220421101708.5640-2-jslaby@suse.cz/
Greg, whichever you take:
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/tty/serial/sunplus-uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sunplus-uart.c b/drivers/tty/serial/sunplus-uart.c
> index 9f15922e681b..60c73662f955 100644
> --- a/drivers/tty/serial/sunplus-uart.c
> +++ b/drivers/tty/serial/sunplus-uart.c
> @@ -498,7 +498,7 @@ static const struct uart_ops sunplus_uart_ops = {
> };
>
> #ifdef CONFIG_SERIAL_SUNPLUS_CONSOLE
> -struct sunplus_uart_port *sunplus_console_ports[SUP_UART_NR];
> +static struct sunplus_uart_port *sunplus_console_ports[SUP_UART_NR];
>
> static void sunplus_uart_console_putchar(struct uart_port *port,
> unsigned char ch)
--
js
suse labs
prev parent reply other threads:[~2022-04-22 5:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 15:25 [PATCH] serial: sunplus-uart: change sunplus_console_ports from global to static Tom Rix
2022-04-22 5:18 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0da4659a-6efb-9734-49cb-968558033a56@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hammerh0314@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox