From: Randy Dunlap <rdunlap@infradead.org>
To: Tom Rix <trix@redhat.com>,
gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: fsl_lpuart: select SERIAL_FSL_LPUART for SERIAL_FSL_LPUART_CONSOLE
Date: Sat, 25 Feb 2023 09:46:37 -0800 [thread overview]
Message-ID: <0f8a8857-5e18-e49a-0361-197b4bc892ab@infradead.org> (raw)
In-Reply-To: <20230225173949.651311-1-trix@redhat.com>
Hi--
On 2/25/23 09:39, Tom Rix wrote:
> A rand config causes this link error
> ld: drivers/tty/serial/earlycon.o: in function `parse_options':
> drivers/tty/serial/earlycon.c:99: undefined reference to `uart_parse_earlycon'
>
> The rand config has
> CONFIG_SERIAL_CORE=m
> CONFIG_SERIAL_EARLYCON=y
> CONFIG_SERIAL_FSL_LPUART=m
> CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
>
> SERIAL_FSL_LPUART should have been selected instead of depends on-ed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 625358f44419..b24d74d389fc 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1313,7 +1313,7 @@ config SERIAL_FSL_LPUART
>
> config SERIAL_FSL_LPUART_CONSOLE
> bool "Console on Freescale lpuart serial port"
> - depends on SERIAL_FSL_LPUART
> + select SERIAL_FSL_LPUART
Most other _CONSOLE Kconfig have:
depends on SERIAL_FSL_LPUART=y
e.g.
but I noticed a few others with a similar problem.
> select SERIAL_CORE_CONSOLE
> select SERIAL_EARLYCON
> help
--
~Randy
next prev parent reply other threads:[~2023-02-25 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 17:39 [PATCH] tty: serial: fsl_lpuart: select SERIAL_FSL_LPUART for SERIAL_FSL_LPUART_CONSOLE Tom Rix
2023-02-25 17:46 ` Randy Dunlap [this message]
2023-02-25 17:51 ` Tom Rix
2023-02-25 18:03 ` Randy Dunlap
2023-02-25 18:16 ` Randy Dunlap
2023-02-25 18:38 ` Randy Dunlap
2023-02-26 15:02 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f8a8857-5e18-e49a-0361-197b4bc892ab@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox