From: Jiri Slaby <jirislaby@kernel.org>
To: Trevor Woerner <twoerner@gmail.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/3] serial: 8250_fintek.c: Report chipID
Date: Fri, 11 Mar 2022 10:21:46 +0100 [thread overview]
Message-ID: <0fb3795e-0ab1-494b-aefd-ccfa78420723@kernel.org> (raw)
In-Reply-To: <20220311070203.18159-2-twoerner@gmail.com>
On 11. 03. 22, 8:02, Trevor Woerner wrote:
> Provide some feedback to confirm this driver is enabled, and specify which
> chip was detected.
No, we don't do that. In fact, the output is mostly useless as it
doesn't even tell the user what device this is about.
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> drivers/tty/serial/8250/8250_fintek.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index d9f0e546b1a1..03ad2354d808 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -155,11 +155,22 @@ static int fintek_8250_check_id(struct fintek_8250 *pdata)
>
> switch (chip) {
> case CHIP_ID_F81865:
> + pr_info("Fintek F81865\n");
> + break;
> case CHIP_ID_F81866:
> + pr_info("Fintek F81866\n");
> + break;
> case CHIP_ID_F81966:
> + pr_info("Fintek F81966\n");
> + break;
> case CHIP_ID_F81216AD:
> + pr_info("Fintek F81216AD\n");
> + break;
> case CHIP_ID_F81216H:
> + pr_info("Fintek F81216H\n");
> + break;
> case CHIP_ID_F81216:
> + pr_info("Fintek F81216\n");
> break;
> default:
> return -ENODEV;
thanks,
--
js
next prev parent reply other threads:[~2022-03-11 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 7:02 [PATCH 2/3] serial: 8250_fintek.c: Report chipID Trevor Woerner
2022-03-11 9:21 ` Jiri Slaby [this message]
2022-03-11 14:26 ` Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fb3795e-0ab1-494b-aefd-ccfa78420723@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).